[vscode-go] extension/src/language: utilize extensions filter in file field

0 views

Skip to first unread message

Hongxiang Jiang (Gerrit)

unread,

Jun 5, 2026, 4:53:53 PM (2 days ago) Jun 5

to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, golang...@luci-project-accounts.iam.gserviceaccount.com, Madeline Kalil, Danny Tuppeny, golang-co...@googlegroups.com

Hongxiang Jiang submitted the change with unreviewed changes

Unreviewed changes

4 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: extension/src/language/form.ts
Insertions: 2, Deletions: 2.

@@ -784,14 +784,14 @@
 	 * Helper to prompt for a single field based on its type.
 	 */
 	private async promptForField(field: FormField, prevAnswer: any | undefined): Promise<any | undefined> {
-		const type = field.type;
+		const fieldType = field.type;
 
-		switch (type.kind) {
+		switch (fieldType.kind) {
 			case 'file': {
 				let actionTarget: 'open' | 'save' | undefined;
-				if (type.existence !== undefined) {
-					const allowsNew = (type.existence & FileExistence.New) !== 0;
-					const allowsExisting = (type.existence & FileExistence.Existing) !== 0;
+				if (fieldType.existence !== undefined) {
+					const allowsNew = (fieldType.existence & FileExistence.New) !== 0;
+					const allowsExisting = (fieldType.existence & FileExistence.Existing) !== 0;
 					if (allowsNew && !allowsExisting) {
 						actionTarget = 'save';
 					} else if (allowsExisting && !allowsNew) {
@@ -854,18 +854,18 @@
 				}
 
 				let filters: { [name: string]: string[] } | undefined;
-				if (type.filters && type.filters.length > 0) {
+				if (fieldType.filters && fieldType.filters.length > 0) {
 					filters = {
-						'Supported Files': type.filters
+						'Supported Files': fieldType.filters
 					};
 				}
 
 				if (actionTarget === 'open') {
 					let canSelectFiles = true;
 					let canSelectFolders = true;
-					if (type.type !== undefined) {
-						canSelectFiles = (type.type & FileType.Regular) !== 0;
-						canSelectFolders = (type.type & FileType.Directory) !== 0;
+					if (fieldType.type !== undefined) {
+						canSelectFiles = (fieldType.type & FileType.Regular) !== 0;
+						canSelectFolders = (fieldType.type & FileType.Directory) !== 0;
 
 						// Safe fallback: if the constraint evaluates to allowing neither (which is
 						// likely a bug/misconfiguration in the language server), allow both so
@@ -908,7 +908,7 @@
 				} as vscode.InputBoxOptions);
 
 			case 'enum': {
-				const pickItems = type.entries.map((entry, _) => {
+				const pickItems = fieldType.entries.map((entry, _) => {
 					return {
 						// Use description if it exists, otherwise use value
 						label: entry.description || entry.value,
@@ -927,7 +927,7 @@
 			}
 
 			case 'lazyEnum': {
-				return await this.pickLazyEnum(field.description, type.source, type.config);
+				return await this.pickLazyEnum(field.description, fieldType.source, fieldType.config);
 			}
 
 			case 'bool': {
@@ -966,7 +966,7 @@
 
 			case 'list': {
 				// Basic support for lists of primitive strings/numbers via comma-separated input
-				if (type.elementType.kind === 'string' || type.elementType.kind === 'number') {
+				if (fieldType.elementType.kind === 'string' || fieldType.elementType.kind === 'number') {
 					const rawList = await vscode.window.showInputBox({
 						prompt: `${field.description} (comma separated)`,
 						ignoreFocusOut: true
@@ -983,14 +983,14 @@
 
 					const parts = rawList.split(',').map((s) => s.trim());
 
-					if (type.elementType.kind === 'number') {
+					if (fieldType.elementType.kind === 'number') {
 						return parts.map(Number).filter((n) => !isNaN(n));
 					}
 					return parts;
 				}
 
 				vscode.window.showErrorMessage(
-					`List input for ${type.elementType.kind} is not supported in this version.`
+					`List input for ${fieldType.elementType.kind} is not supported in this version.`
 				);
 				return undefined;
 			}
```

Change information

Commit message:

extension/src/language: utilize extensions filter in file field

Some small change based on linter from dart-code.

For golang/go#76331

Change-Id: I1c0d550b2df04a62c00ba06bc6cebc945425d44d

Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/786123

LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>

Reviewed-by: Danny Tuppeny <da...@tuppeny.com>

Reviewed-by: Madeline Kalil <mka...@google.com>

Files:

M extension/src/language/form.ts

Change size: S

Delta: 1 file changed, 19 insertions(+), 13 deletions(-)

Branch: refs/heads/master

Submit Requirements:

Code-Review: +1 by Danny Tuppeny, +2 by Madeline Kalil
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages