[go] go/ypes, types2: rename Named.under to Named.resolveUnderlying
0 views
Skip to first unread message
Gopher Robot (Gerrit)
Oct 22, 2025, 11:20:37 AM (22 hours ago) Oct 22
to Robert Griesemer, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Go LUCI, Mark Freeman, Robert Griesemer, Robert Findley, golang-co...@googlegroups.com
Gopher Robot submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
3 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: src/go/types/named.go
Insertions: 5, Deletions: 5.
The diff is too large to show. Please review the diff.
```
```
The name of the file: src/cmd/compile/internal/types2/named.go
Insertions: 5, Deletions: 5.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
go/types, types2: rename Named.under to Named.resolveUnderlying
Named.resolveUnderlying is now just a helper function for Underlying
and only called from there. The name makes is clearer what this function
does; it also doesn't need to return a result anymore.
While at it, slightly simplify the function body.
Change-Id: I167c4be89b1bfcc69f6b528ddb6ed4c90481194a
Reviewed-on: https://go-review.googlesource.com/c/go/+/712521
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Mark Freeman <markf...@google.com>
Auto-Submit: Robert Griesemer <g...@google.com>
Reviewed-by: Robert Griesemer <g...@google.com>
Files:
- M src/cmd/compile/internal/types2/named.go
- M src/go/types/named.go
Change size: M
Delta: 2 files changed, 28 insertions(+), 30 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +1 by Robert Griesemer, +2 by Mark Freeman
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages