[build] cmd: remove redundant type conversion

0 views
Skip to first unread message

Gopher Robot (Gerrit)

unread,
Sep 7, 2022, 1:19:12 PM9/7/22
to shuang cui, Gerrit Bot, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Dmitri Shuralyov, Dmitri Shuralyov, Heschi Kreinick, Brad Fitzpatrick, Carlos Amedee, golang-co...@googlegroups.com

Gopher Robot submitted this change.

View Change


Approvals: Heschi Kreinick: Looks good to me, approved Dmitri Shuralyov: Looks good to me, but someone else must approve Dmitri Shuralyov: Looks good to me, approved; Run TryBots; Automatically submit change Gopher Robot: TryBots succeeded
cmd/gerritbot: remove redundant type conversion

Change-Id: I14bc99997d72801a933a1554ea7ab6b0db3aa3ea
GitHub-Last-Rev: 3c12de9cfe525853515380ac816e54172d317d19
GitHub-Pull-Request: golang/build#45
Reviewed-on: https://go-review.googlesource.com/c/build/+/428981
TryBot-Result: Gopher Robot <go...@golang.org>
Run-TryBot: Dmitri Shuralyov <dmit...@golang.org>
Reviewed-by: Dmitri Shuralyov <dmit...@golang.org>
Auto-Submit: Dmitri Shuralyov <dmit...@golang.org>
Reviewed-by: Dmitri Shuralyov <dmit...@google.com>
Reviewed-by: Heschi Kreinick <hes...@google.com>
---
M cmd/gerritbot/gerritbot.go
1 file changed, 21 insertions(+), 3 deletions(-)

diff --git a/cmd/gerritbot/gerritbot.go b/cmd/gerritbot/gerritbot.go
index 48207b6..ef1b85d 100644
--- a/cmd/gerritbot/gerritbot.go
+++ b/cmd/gerritbot/gerritbot.go
@@ -876,7 +876,7 @@
}
// See if there is a dup comment from when GerritBot last got
// its data from maintner.
- ics, resp, err := b.githubClient.Issues.ListComments(ctx, org, repo, int(issueNum), &github.IssueListCommentsOptions{
+ ics, resp, err := b.githubClient.Issues.ListComments(ctx, org, repo, issueNum, &github.IssueListCommentsOptions{
Since: since,
ListOptions: github.ListOptions{PerPage: 1000},
})
@@ -897,7 +897,7 @@
return err
}
logGitHubRateLimits(resp)
- ownerID = int64(issue.GetUser().GetID())
+ ownerID = issue.GetUser().GetID()
}
for _, ic := range ics {
if strings.Contains(ic.GetBody(), msg) {
@@ -905,7 +905,7 @@
return nil
}
body := ic.GetBody()
- if int64(ic.GetUser().GetID()) == ownerID && strings.HasPrefix(body, "/comments ") {
+ if ic.GetUser().GetID() == ownerID && strings.HasPrefix(body, "/comments ") {
if strings.HasPrefix(body, "/comments off") {
noComment = true
} else if strings.HasPrefix(body, "/comments on") {

To view, visit change 428981. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: build
Gerrit-Branch: master
Gerrit-Change-Id: I14bc99997d72801a933a1554ea7ab6b0db3aa3ea
Gerrit-Change-Number: 428981
Gerrit-PatchSet: 3
Gerrit-Owner: Gerrit Bot <letsus...@gmail.com>
Gerrit-Reviewer: Brad Fitzpatrick <brad...@golang.org>
Gerrit-Reviewer: Carlos Amedee <car...@golang.org>
Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org>
Gerrit-Reviewer: Dmitri Shuralyov <dmit...@google.com>
Gerrit-Reviewer: Gopher Robot <go...@golang.org>
Gerrit-Reviewer: Heschi Kreinick <hes...@google.com>
Gerrit-CC: shuang cui <imc...@gmail.com>
Gerrit-MessageType: merged
Reply all
Reply to author
Forward
0 new messages