[tools] go/analysis: don't apply fixes to generated files

[Gopher Robot (Gerrit)]

Gopher Robot submitted the change

Unreviewed changes

6 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:

go/analysis: don't apply fixes to generated files

This change causes the analysis drivers unitchecker,
{single,multi}checker, and analysistest to discard any
fix any of whose edits is in a generated Go source file
(as defined by ast.IsGenerated).

gopls's analysis driver is not yet covered.

(It would be nice if more of the "fix" logic of analysistest
could be consolidated with the various checkers.)

+ test of analysistest (via modernize_test)
+ test of unitchecker

Fixes golang/go#75948

Change-Id: I96a4abf605657392a6dbb58b22a036dc8f9f6d44

Reviewed-on: https://go-review.googlesource.com/c/tools/+/718505

LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Auto-Submit: Alan Donovan <adon...@google.com>

Reviewed-by: Hongxiang Jiang <hxj...@golang.org>

Files:

• M go/analysis/analysistest/analysistest.go
• M go/analysis/internal/checker/checker.go
• M go/analysis/passes/modernize/any.go
• M go/analysis/passes/modernize/bloop.go
• M go/analysis/passes/modernize/errorsastype.go
• M go/analysis/passes/modernize/fmtappendf.go
• M go/analysis/passes/modernize/forvar.go
• M go/analysis/passes/modernize/maps.go
• M go/analysis/passes/modernize/minmax.go
• M go/analysis/passes/modernize/modernize.go
• M go/analysis/passes/modernize/modernize_test.go
• M go/analysis/passes/modernize/omitzero.go
• M go/analysis/passes/modernize/rangeint.go
• M go/analysis/passes/modernize/reflect.go
• M go/analysis/passes/modernize/slices.go
• M go/analysis/passes/modernize/slicescontains.go
• M go/analysis/passes/modernize/slicesdelete.go
• M go/analysis/passes/modernize/sortslice.go
• M go/analysis/passes/modernize/stditerators.go
• M go/analysis/passes/modernize/stringsbuilder.go
• M go/analysis/passes/modernize/stringscut.go
• M go/analysis/passes/modernize/stringscutprefix.go
• M go/analysis/passes/modernize/stringsseq.go
• A go/analysis/passes/modernize/testdata/src/any/generated.go
• A go/analysis/passes/modernize/testdata/src/any/generated.go.golden
• M go/analysis/passes/modernize/testingcontext.go
• M go/analysis/passes/modernize/waitgroup.go
• M go/analysis/unitchecker/unitchecker.go
• M go/analysis/unitchecker/unitchecker_test.go
• M internal/analysis/driverutil/fix.go

Change size: L

Delta: 30 files changed, 151 insertions(+), 156 deletions(-)

Branch: refs/heads/master

Submit Requirements:

• Code-Review: +2 by Hongxiang Jiang
• TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: tools

Gerrit-Branch: master

Gerrit-Change-Id: I96a4abf605657392a6dbb58b22a036dc8f9f6d44

Gerrit-Change-Number: 718505

Gerrit-PatchSet: 9

Gerrit-Owner: Alan Donovan <adon...@google.com>

Gerrit-Reviewer: Alan Donovan <adon...@google.com>

Gerrit-Reviewer: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Gopher Robot <go...@golang.org>

Gerrit-Reviewer: Hongxiang Jiang <hxj...@golang.org>

Gerrit-CC: Dominik Honnef <dom...@honnef.co>

Gerrit-CC: Robert Findley <rfin...@google.com>