[go] cmd/go: make the package loader a part of the module loader
0 views
Skip to first unread message
Michael Matloob (Gerrit)
12:35 PM (6 hours ago) 12:35 PM
to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Ian Alexander, Go LUCI, Michael Matloob, golang-co...@googlegroups.com
Michael Matloob submitted the change![]( "Open in Gerrit")
Change information
Commit message:
cmd/go: make the package loader a part of the module loader
This is a part of the project to remove global state in the module
loader. Before this change, the packageLoader was stored in a global
field "loaded" which meant that even though the module loader is no
longer global, part of the module loader still depended on global state.
This change will make progress to the point where we can potentially
have multiple module loaders in the same go/command execution.
Change-Id: If4963a8a9d0e04960cf5424e496114276a6a6964
Reviewed-on: https://go-review.googlesource.com/c/go/+/753220
Reviewed-by: Ian Alexander <ji...@google.com>
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Matloob <mat...@google.com>
Files:
- M src/cmd/go/internal/modcmd/vendor.go
- M src/cmd/go/internal/modcmd/why.go
- M src/cmd/go/internal/modget/get.go
- M src/cmd/go/internal/modload/build.go
- M src/cmd/go/internal/modload/init.go
- M src/cmd/go/internal/modload/load.go
- M src/cmd/go/internal/workcmd/sync.go
Change size: M
Delta: 7 files changed, 37 insertions(+), 37 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +2 by Ian Alexander, +1 by Michael Matloob
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages