[go] cmd/compile: fix mis-compilation for static array initialization

[Gopher Robot (Gerrit)]

Gopher Robot submitted the change

Change information

Commit message:

cmd/compile: fix mis-compilation for static array initialization

The bug was first introduced when the compiler is still written in C,
with CL 2254041. The static array was laid out with the wrong context,
causing a stack pointer will be stored in global object.

Fixes #61730
Fixes #77193

Change-Id: I22c8393314d251beb53db537043a63714c84f36a

Reviewed-on: https://go-review.googlesource.com/c/go/+/737821

Reviewed-by: Dmitri Shuralyov <dmit...@google.com>

Reviewed-by: Keith Randall <k...@golang.org>

Reviewed-by: Keith Randall <k...@google.com>

LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Auto-Submit: Keith Randall <k...@golang.org>

Files:

• M src/cmd/compile/internal/walk/complit.go
• M test/codegen/slices.go

Change size: S

Delta: 2 files changed, 13 insertions(+), 5 deletions(-)

Branch: refs/heads/master

Submit Requirements:

• Code-Review: +1 by Keith Randall, +2 by Keith Randall, +1 by Dmitri Shuralyov
• TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: go

Gerrit-Branch: master

Gerrit-Change-Id: I22c8393314d251beb53db537043a63714c84f36a

Gerrit-Change-Number: 737821

Gerrit-PatchSet: 2

Gerrit-Owner: Cuong Manh Le <cuong.m...@gmail.com>

Gerrit-Reviewer: Cuong Manh Le <cuong.m...@gmail.com>

Gerrit-Reviewer: Dmitri Shuralyov <dmit...@google.com>

Gerrit-Reviewer: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Gopher Robot <go...@golang.org>

Gerrit-Reviewer: Keith Randall <k...@golang.org>

Gerrit-Reviewer: Keith Randall <k...@google.com>

Gerrit-Reviewer: Michael Knyszek <mkny...@google.com>

Gerrit-CC: Dmitri Shuralyov <dmit...@golang.org>