[vscode-go] extension/src/language: extend range support to type def

0 views
Skip to first unread message

Gopher Robot (Gerrit)

unread,
Dec 16, 2025, 3:29:48 PM (13 hours ago) Dec 16
to Hongxiang Jiang, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Go LUCI, Alan Donovan, Madeline Kalil, golang-co...@googlegroups.com

Gopher Robot submitted the change with unreviewed changes

Unreviewed changes

1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: extension/src/language/goLanguageServer.ts
Insertions: 1, Deletions: 1.

@@ -623,7 +623,7 @@
return res;
} catch (e) {
// Suppress error messages for frequently triggered
- // or programmerly triggered commads.
+ // or programmatically triggered commads.
if (command === 'gopls.package_symbols' || command === 'gopls.lsp') {
return null;
}
```

Change information

Commit message:
extension/src/language: extend range support to type def

gopls.lsp is triggered programmatically by the language client,
if error encountered, the vscode will pop up notifications
as if the ongoing LSP method is blocking. This CL also
suppress the error encountered gopls.lsp command.

Gopls CL 728600

For golang/go#76723
Change-Id: Ia064a7bb149bee632198c7affb0e975de2fe7e0c
Reviewed-by: Madeline Kalil <mka...@google.com>
Auto-Submit: Hongxiang Jiang <hxj...@golang.org>
Files:
  • M extension/src/language/goLanguageServer.ts
Change size: S
Delta: 1 file changed, 29 insertions(+), 3 deletions(-)
Branch: refs/heads/master
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by Madeline Kalil
  • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: vscode-go
Gerrit-Branch: master
Gerrit-Change-Id: Ia064a7bb149bee632198c7affb0e975de2fe7e0c
Gerrit-Change-Number: 727560
Gerrit-PatchSet: 6
Gerrit-Owner: Hongxiang Jiang <hxj...@golang.org>
Gerrit-Reviewer: Gopher Robot <go...@golang.org>
Gerrit-Reviewer: Hongxiang Jiang <hxj...@golang.org>
Gerrit-Reviewer: Madeline Kalil <mka...@google.com>
Gerrit-CC: Alan Donovan <adon...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages