[dl] internal/version: set GOTOOLCHAIN=local+auto for gotip

[Hyang-Ah Hana Kim (Gerrit)]

Hyang-Ah Hana Kim submitted the change

Change information

Commit message:

gotip: explicitly set GOTOOLCHAIN=auto

Address issue 64665 by setting GOTOOLCHAIN=auto
if GOTOOLCHAIN env var is not explicitly configured
when invoking the real go binary from the gotip wrapper.
This ensures that user's global GOTOOLCHAIN setting
(set by `go env -w`) doesn't override gotip behavior.
Other version wrappers' behavior is left unchanged.

Fixes golang/go#64665

Change-Id: I076d34e88de8d149542085c494d4c1c31b7f379e

Reviewed-on: https://go-review.googlesource.com/c/dl/+/763260

Reviewed-by: Michael Matloob <mat...@golang.org>

LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Reviewed-by: Dmitri Shuralyov <dmit...@golang.org>

Reviewed-by: Michael Matloob <mat...@google.com>

Files:

• M gotip/main.go
• M internal/version/gotip.go
• M internal/version/version.go
• M internal/version/version_test.go

Change size: M

Delta: 4 files changed, 80 insertions(+), 8 deletions(-)

Branch: refs/heads/master

Submit Requirements:

• Code-Review: +1 by Michael Matloob, +2 by Michael Matloob, +2 by Dmitri Shuralyov
• TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: dl

Gerrit-Branch: master

Gerrit-Change-Id: I076d34e88de8d149542085c494d4c1c31b7f379e

Gerrit-Change-Number: 763260

Gerrit-PatchSet: 6

Gerrit-Owner: Hyang-Ah Hana Kim <hya...@gmail.com>

Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org>

Gerrit-Reviewer: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Hyang-Ah Hana Kim <hya...@gmail.com>

Gerrit-Reviewer: Michael Matloob <mat...@golang.org>

Gerrit-Reviewer: Michael Matloob <mat...@google.com>