[go/release-branch.go1.25] [release-branch.go1.25] cmd/compile: handle min integer step in loop

0 views
Skip to first unread message

Carlos Amedee (Gerrit)

unread,
Apr 23, 2026, 4:27:59 PM (2 days ago) Apr 23
to Cuong Manh Le, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Dmitri Shuralyov, Mark Freeman, Keith Randall, David Chase, golang...@luci-project-accounts.iam.gserviceaccount.com, Keith Randall, golang-co...@googlegroups.com

Carlos Amedee submitted the change

Change information

Commit message:
[release-branch.go1.25] cmd/compile: handle min integer step in loop

Since negating min int will overflows back to itself, causing a panic
inside subWillUnderflow check.

Fixes #78675
Change-Id: Ibbf2fa3228b9890a1a76ac6f4ff504b7e125b29f
Auto-Submit: Cuong Manh Le <cuong.m...@gmail.com>
Reviewed-by: David Chase <drc...@google.com>
Reviewed-by: Jorropo <jorro...@gmail.com>
Reviewed-by: Keith Randall <k...@google.com>
TryBot-Bypass: Dmitri Shuralyov <dmit...@golang.org>
Files:
  • M src/cmd/compile/internal/ssa/loopbce.go
  • A test/fixedbugs/issue78641.go
Change size: S
Delta: 2 files changed, 31 insertions(+), 0 deletions(-)
Branch: refs/heads/release-branch.go1.25
Submit Requirements:
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: go
Gerrit-Branch: release-branch.go1.25
Gerrit-Change-Id: Ibbf2fa3228b9890a1a76ac6f4ff504b7e125b29f
Gerrit-Change-Number: 766860
Gerrit-PatchSet: 2
Gerrit-Owner: Cuong Manh Le <cuong.m...@gmail.com>
Gerrit-Reviewer: Carlos Amedee <car...@golang.org>
Gerrit-Reviewer: Cuong Manh Le <cuong.m...@gmail.com>
Gerrit-Reviewer: David Chase <drc...@google.com>
Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org>
Gerrit-Reviewer: Keith Randall <k...@golang.org>
Gerrit-Reviewer: Keith Randall <k...@google.com>
Gerrit-CC: Mark Freeman <markf...@google.com>
open
diffy
satisfied_requirement

Carlos Amedee (Gerrit)

unread,
Apr 23, 2026, 4:28:06 PM (2 days ago) Apr 23
to Cuong Manh Le, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Keith Randall, David Chase, golang...@luci-project-accounts.iam.gserviceaccount.com, Keith Randall, golang-co...@googlegroups.com

Carlos Amedee submitted the change

Change information

Commit message:
[release-branch.go1.26] cmd/compile: handle min integer step in loop


Since negating min int will overflows back to itself, causing a panic
inside subWillUnderflow check.

Fixes #78676
Change-Id: Ibbf2fa3228b9890a1a76ac6f4ff504b7e125b29f
Auto-Submit: Cuong Manh Le <cuong.m...@gmail.com>
Reviewed-by: David Chase <drc...@google.com>
Reviewed-by: Jorropo <jorro...@gmail.com>
Reviewed-by: Keith Randall <k...@google.com>
Files:
  • M src/cmd/compile/internal/ssa/loopbce.go
  • A test/fixedbugs/issue78641.go
Change size: S
Delta: 2 files changed, 31 insertions(+), 0 deletions(-)
Branch: refs/heads/release-branch.go1.26
Submit Requirements:
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: go
Gerrit-Branch: release-branch.go1.26
Gerrit-Change-Id: Ibbf2fa3228b9890a1a76ac6f4ff504b7e125b29f
Gerrit-Change-Number: 766840
Gerrit-PatchSet: 2
Gerrit-Owner: Cuong Manh Le <cuong.m...@gmail.com>
Gerrit-Reviewer: Carlos Amedee <car...@golang.org>
Gerrit-Reviewer: Cuong Manh Le <cuong.m...@gmail.com>
Gerrit-Reviewer: David Chase <drc...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages