[go] os: ignore SIGSYS in checkPidfd

2 views
Skip to first unread message

Gopher Robot (Gerrit)

unread,
Sep 26, 2024, 9:17:19 AM9/26/24
to cions, Gerrit Bot, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, David Chase, Go LUCI, Ian Lance Taylor, Cherry Mui, Kirill Kolyshkin, Brad Fitzpatrick, Michael Pratt, golang-co...@googlegroups.com

Gopher Robot submitted the change

Change information

Commit message:
os: ignore SIGSYS in checkPidfd

In Android version 11 and earlier, pidfd-related system calls
are not allowed by the seccomp policy, which causes crashes due
to SIGSYS signals.

Fixes #69065
Change-Id: Ib29631639a5cf221ac11b4d82390cb79436b8657
GitHub-Last-Rev: aad6b3b32c81795f86bc4a9e81aad94899daf520
GitHub-Pull-Request: golang/go#69543
Auto-Submit: Ian Lance Taylor <ia...@google.com>
Reviewed-by: David Chase <drc...@google.com>
Reviewed-by: Ian Lance Taylor <ia...@google.com>
Files:
  • M src/os/pidfd_linux.go
  • M src/runtime/os_linux.go
  • M src/runtime/os_unix_nonlinux.go
  • M src/runtime/signal_unix.go
Change size: M
Delta: 4 files changed, 51 insertions(+), 2 deletions(-)
Branch: refs/heads/master
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by David Chase, +2 by Ian Lance Taylor
  • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Ib29631639a5cf221ac11b4d82390cb79436b8657
Gerrit-Change-Number: 614277
Gerrit-PatchSet: 5
Gerrit-Owner: Gerrit Bot <letsus...@gmail.com>
Gerrit-Reviewer: Brad Fitzpatrick <brad...@golang.org>
Gerrit-Reviewer: Cherry Mui <cher...@google.com>
Gerrit-Reviewer: David Chase <drc...@google.com>
Gerrit-Reviewer: Gopher Robot <go...@golang.org>
Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>
Gerrit-Reviewer: Ian Lance Taylor <ia...@google.com>
Gerrit-Reviewer: Kirill Kolyshkin <koly...@gmail.com>
Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
Gerrit-CC: cions <gh.c...@gmail.com>
open
diffy
satisfied_requirement

Gopher Robot (Gerrit)

unread,
Oct 2, 2024, 12:52:31 PM10/2/24
to cions, Ian Lance Taylor, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Dmitri Shuralyov, Dmitri Shuralyov, Michael Knyszek, Kirill Kolyshkin, Go LUCI, Mauri de Souza Meneguzzo, David Chase, golang-co...@googlegroups.com

Gopher Robot submitted the change

Change information

Commit message:
[release-branch.go1.23] os: ignore SIGSYS in checkPidfd


In Android version 11 and earlier, pidfd-related system calls
are not allowed by the seccomp policy, which causes crashes due
to SIGSYS signals.

For #69065
Fixes #69640


Change-Id: Ib29631639a5cf221ac11b4d82390cb79436b8657
GitHub-Last-Rev: aad6b3b32c81795f86bc4a9e81aad94899daf520
GitHub-Pull-Request: golang/go#69543
Reviewed-on: https://go-review.googlesource.com/c/go/+/614277
Auto-Submit: Ian Lance Taylor <ia...@google.com>
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: David Chase <drc...@google.com>
Reviewed-by: Ian Lance Taylor <ia...@google.com>
(cherry picked from commit a3a05ed04cb53c53bdacded2d16f0f3e5facdbb0)
Reviewed-on: https://go-review.googlesource.com/c/go/+/616077
Reviewed-by: Michael Knyszek <mkny...@google.com>
Reviewed-by: Kirill Kolyshkin <koly...@gmail.com>
Reviewed-by: Dmitri Shuralyov <dmit...@google.com>
Reviewed-by: Mauri de Souza Meneguzzo <maur...@gmail.com>
Auto-Submit: Michael Knyszek <mkny...@google.com>
Files:
  • M src/os/pidfd_linux.go
  • M src/runtime/os_linux.go
  • M src/runtime/os_unix_nonlinux.go
  • M src/runtime/signal_unix.go
Change size: M
Delta: 4 files changed, 51 insertions(+), 2 deletions(-)
Branch: refs/heads/release-branch.go1.23
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Dmitri Shuralyov, +1 by Mauri de Souza Meneguzzo, +2 by Michael Knyszek, +1 by Kirill Kolyshkin
  • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: go
Gerrit-Branch: release-branch.go1.23
Gerrit-Change-Id: Ib29631639a5cf221ac11b4d82390cb79436b8657
Gerrit-Change-Number: 616077
Gerrit-PatchSet: 3
Gerrit-Owner: Ian Lance Taylor <ia...@golang.org>
Gerrit-Reviewer: David Chase <drc...@google.com>
Gerrit-Reviewer: Dmitri Shuralyov <dmit...@google.com>
Gerrit-Reviewer: Gopher Robot <go...@golang.org>
Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>
Gerrit-Reviewer: Ian Lance Taylor <ia...@google.com>
Gerrit-Reviewer: Kirill Kolyshkin <koly...@gmail.com>
Gerrit-Reviewer: Mauri de Souza Meneguzzo <maur...@gmail.com>
Gerrit-Reviewer: Michael Knyszek <mkny...@google.com>
Gerrit-CC: Dmitri Shuralyov <dmit...@golang.org>
Gerrit-CC: cions <gh.c...@gmail.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages