[go] runtime: unify mallocStub fast/slow blocks
0 views
Skip to first unread message
Gopher Robot (Gerrit)
Jun 25, 2026, 3:45:25 PM (2 days ago) Jun 25
to Michael Pratt, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Michael Matloob, Michael Matloob, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Gopher Robot submitted the change![]( "Open in Gerrit")
Change information
Commit message:
runtime: unify mallocStub fast/slow blocks
Inside mallocStub, combine all of the fast path (!isSlowPath_) logic
into a single block, and all of the slow path logic into a single block.
This is primarily a refactor with no semantic change. The intention is
to make it easier to read which part are fast/slow, and to make it
easier for a follow up to change to acquirem early in the fast path.
The only semantic change is to move doubleCheckMalloc earlier. If the
fast path decides to fall back to the slow path, that case will execute
twice, but it is a trivial check and it's even compiled in by default.
This arrangement does require duplicating lockRankMayQueueFinalizer in
both blocks. We can't move it earlier because the fast path falling back
to the slow path would call this twice, which would trigger a lock rank
violation. We could potentially move it below (just before
inlineMalloc). I don't believe it needs to come before
deductAssistCredit, but I'd rather do that in a separate change.
For #79667.
For #79699.
Change-Id: I1101cb112e0c48280c0317d986607ba66a6a6964
Reviewed-on: https://go-review.googlesource.com/c/go/+/794120
Reviewed-by: Michael Matloob <mat...@google.com>
Reviewed-by: Michael Matloob <mat...@golang.org>
Auto-Submit: Michael Pratt <mpr...@google.com>
LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>
Files:
- M src/runtime/malloc_generated.go
- M src/runtime/malloc_stubs.go
Change size: M
Delta: 2 files changed, 111 insertions(+), 117 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +2 by Michael Matloob, +1 by Michael Matloob
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages