[tools] gopls/test/completion: fix reported bug in collectCompletions

[Peter Weinberger (Gerrit)]

Peter Weinberger submitted the change

Change information

Commit message:

gopls/test/completion: fix reported bug in collectCompletions

The bug reporter has reported multiple occurrences of an unexpected
case in determining completions, namely completing in
notypeinfo.(type)

This code handles that case, and tests that the requested completion
no longer panics.

Fixes: golang/go#75192

Change-Id: I191468430c7554301e0ecd7b17d24e97e1bbfa7d

Reviewed-on: https://go-review.googlesource.com/c/tools/+/805221

Reviewed-by: Alan Donovan <adon...@google.com>

LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>

Files:

• M gopls/internal/golang/completion/completion.go
• M gopls/internal/test/integration/completion/completion_test.go

Change size: S

Delta: 2 files changed, 25 insertions(+), 6 deletions(-)

Branch: refs/heads/master

Submit Requirements:

• Code-Review: +2 by Alan Donovan
• TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: tools

Gerrit-Branch: master

Gerrit-Change-Id: I191468430c7554301e0ecd7b17d24e97e1bbfa7d

Gerrit-Change-Number: 805221

Gerrit-PatchSet: 2

Gerrit-Owner: Peter Weinberger <p...@google.com>

Gerrit-Reviewer: Alan Donovan <adon...@google.com>

Gerrit-Reviewer: Peter Weinberger <p...@google.com>

Gerrit-Reviewer: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>