[benchmarks] sweet: collect and dump only hijacked fd 2 for cockroachdb

[Michael Knyszek (Gerrit)]

Michael Knyszek submitted the change

Change information

Commit message:

sweet: collect and dump only hijacked fd 2 for cockroachdb

Currently the performance testing builders are failing because the
CockroachDB servers produce far too much log data for
perfdata.golang.org to handle, and it gets shipped off along with the
benchmark data (it just ends up in the result file). This change stops
logging everything CockroachDB does to stderr and instead redirects to a
dedicated directory. This directory should remain if anything goes
wrong, so we can still use it for debugging, but in normal usage it'll
get blown away. The one thing we want from this directory, however, is
the output originally sent to fd 2 before it was hijacked by
CockroachDB. This output includes things like runtime printlns from
GODEBUG=gctrace=1, among other things, which is important to preserve
for our debugging.

Fixes golang/go#68517.

Change-Id: I319d37e174675a1e7de7d9fcb4ca06076c6c8daf

Cq-Include-Trybots: luci.golang.try:x_benchmarks-gotip-linux-amd64-longtest

Reviewed-on: https://go-review.googlesource.com/c/benchmarks/+/599455

LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Reviewed-by: Austin Clements <aus...@google.com>

Files:

• M sweet/benchmarks/cockroachdb/main.go

Change size: S

Delta: 1 file changed, 12 insertions(+), 4 deletions(-)

Branch: refs/heads/master

Submit Requirements:

• Code-Review: +2 by Austin Clements
• TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: benchmarks

Gerrit-Branch: master

Gerrit-Change-Id: I319d37e174675a1e7de7d9fcb4ca06076c6c8daf

Gerrit-Change-Number: 599455

Gerrit-PatchSet: 5

Gerrit-Owner: Michael Knyszek <mkny...@google.com>

Gerrit-Reviewer: Austin Clements <aus...@google.com>

Gerrit-Reviewer: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Michael Knyszek <mkny...@google.com>