[build] cmd/gopherbot: use strings.FieldsFuncSeq to reduce memory allocations

1 view
Skip to first unread message

Gopher Robot (Gerrit)

unread,
Sep 30, 2025, 11:29:09 AM (yesterday) Sep 30
to shuang cui, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Dmitri Shuralyov, Carlos Amedee, Dmitri Shuralyov, Go LUCI, golang-co...@googlegroups.com

Gopher Robot submitted the change

Change information

Commit message:
cmd/gopherbot: use strings.FieldsFuncSeq

Use the iterator form to avoid constructing a slice needlessly.
See CL 639536 as an example of analogous change for net/http.
Change-Id: If78f805794dd21a0ac102d27c431c1bb4aa98ede
Auto-Submit: Dmitri Shuralyov <dmit...@golang.org>
Reviewed-by: Carlos Amedee <car...@golang.org>
Reviewed-by: Dmitri Shuralyov <dmit...@golang.org>
Reviewed-by: Dmitri Shuralyov <dmit...@google.com>
Files:
  • M cmd/gopherbot/gopherbot.go
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/master
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Carlos Amedee, +2 by Dmitri Shuralyov, +1 by Dmitri Shuralyov
  • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: build
Gerrit-Branch: master
Gerrit-Change-Id: If78f805794dd21a0ac102d27c431c1bb4aa98ede
Gerrit-Change-Number: 707455
Gerrit-PatchSet: 4
Gerrit-Owner: shuang cui <imc...@gmail.com>
Gerrit-Reviewer: Carlos Amedee <car...@golang.org>
Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org>
Gerrit-Reviewer: Dmitri Shuralyov <dmit...@google.com>
Gerrit-Reviewer: Gopher Robot <go...@golang.org>
Gerrit-Reviewer: shuang cui <imc...@gmail.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages