[go] debug/pe: avoid panic in File.ImportedSymbols

0 views

Skip to first unread message

Alex Brainman (Gerrit)

unread,

Dec 22, 2025, 10:38:47 PM (12 hours ago) Dec 22

to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Cherry Mui, Michael Knyszek, Emmanuel Odeke, Keith Randall, Dmitri Shuralyov, Go LUCI, Ian Lance Taylor, golang-co...@googlegroups.com

Alex Brainman submitted the change

Change information

Commit message:

debug/pe: avoid panic in File.ImportedSymbols

This change skips symbols where dt.OriginalFirstThunk is less than
ds.VirtualAddress.

The variable types are uint32, and
(dt.OriginalFirstThunk-ds.VirtualAddress) becomes very large number when
dt.OriginalFirstThunk < ds.VirtualAddress.

Fixes #73548.
Fixes #76721.
Fixes #76724.

Change-Id: I72908bd0896003423aeb754fa0b6c72d452cdb4e

Reviewed-on: https://go-review.googlesource.com/c/go/+/684495

LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Reviewed-by: Emmanuel Odeke <emma...@orijtech.com>

Reviewed-by: Ian Lance Taylor <ia...@golang.org>

Reviewed-by: Cherry Mui <cher...@google.com>

Reviewed-by: Michael Knyszek <mkny...@google.com>

Files:

M src/debug/pe/file.go

Change size: S

Delta: 1 file changed, 16 insertions(+), 2 deletions(-)

Branch: refs/heads/master

Submit Requirements:

Code-Review: +2 by Emmanuel Odeke, +1 by Michael Knyszek, +1 by Cherry Mui, +2 by Ian Lance Taylor
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages