[go] runtime: on android/arm64, don't read outside 16-byte regions

0 views

Skip to first unread message

Gopher Robot (Gerrit)

unread,

Feb 27, 2026, 5:43:58 PM (24 hours ago) Feb 27

to Keith Randall, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Go LUCI, Keith Randall, Michael Pratt, golang-co...@googlegroups.com

Gopher Robot submitted the change with unreviewed changes

Unreviewed changes

1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: src/runtime/string.go
Insertions: 1, Deletions: 1.

@@ -508,7 +508,7 @@
 	// actual system page size is larger than this value.
 	// For Android, we set the page size to the MTE size, as MTE
 	// might be enforced. See issue 59090.
-	const pageSize = 4096 - 4080*goos.IsAndroid
+	const pageSize = 4096*(1-goos.IsAndroid) + 16*goos.IsAndroid
 
 	offset := 0
 	ptr := unsafe.Pointer(s)
```

Change information

Commit message:

runtime: on android/arm64, don't read outside 16-byte regions

Because MTE might be enforced.

Update #59090
Update #27610

Change-Id: Idfaecbf3b7a93c5e371abcace666febfc303de9a

Reviewed-on: https://go-review.googlesource.com/c/go/+/749062

Reviewed-by: Michael Pratt <mpr...@google.com>

Auto-Submit: Keith Randall <k...@golang.org>

LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Reviewed-by: Keith Randall <k...@google.com>

Files:

M src/internal/bytealg/indexbyte_arm64.s
M src/runtime/string.go

Change size: S

Delta: 2 files changed, 25 insertions(+), 1 deletion(-)

Branch: refs/heads/master

Submit Requirements:

Code-Review: +1 by Keith Randall, +2 by Michael Pratt
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages