[go] cmd/link: simplify PE relocations mapping

[Quim Muntal (Gerrit)]

Quim Muntal submitted the change

Change information

Commit message:

cmd/link: simplify PE relocations mapping

The code for mapping Windows PE relocations to Go relocations was
difficult to follow and contains some duplicated code. Also, it was
mapping IMAGE_REL_AMD64_ADDR32 to R_PCREL instead of R_ADDR.

This CL commit simplifies the code and fixes the mapping. I haven't been
able to coerce mingw-w64 to generate IMAGE_REL_AMD64_ADDR32 relocations,
so I haven't been able to test this change. However, the previous
implementation was clearly wrong.

While here, remove code supporting the unsupported windows/arm support.

Updates #71671
Updates #75485

Change-Id: Id0d6f352fa7d5df9e00509fcdf09ca0cb91ca524

Reviewed-on: https://go-review.googlesource.com/c/go/+/672155

Reviewed-by: Michael Knyszek <mkny...@google.com>

Reviewed-by: Cherry Mui <cher...@google.com>

LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Files:

• M src/cmd/link/internal/loadpe/ldpe.go

Change size: M

Delta: 1 file changed, 37 insertions(+), 73 deletions(-)

Branch: refs/heads/master

Submit Requirements:

• Code-Review: +2 by Cherry Mui, +1 by Michael Knyszek
• TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: go

Gerrit-Branch: master

Gerrit-Change-Id: Id0d6f352fa7d5df9e00509fcdf09ca0cb91ca524

Gerrit-Change-Number: 672155

Gerrit-PatchSet: 5

Gerrit-Owner: Quim Muntal <quimm...@gmail.com>

Gerrit-Reviewer: Cherry Mui <cher...@google.com>

Gerrit-Reviewer: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Michael Knyszek <mkny...@google.com>

Gerrit-Reviewer: Quim Muntal <quimm...@gmail.com>