[go] cmd/compile: allow halt flag to run concurrently

0 views
Skip to first unread message

Gopher Robot (Gerrit)

unread,
12:17 PM (5 hours ago) 12:17 PM
to Daniel Morsing, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Robert Griesemer, David Chase, Cherry Mui, Go LUCI, Robert Griesemer, Keith Randall, Martin Möhrmann, golang-co...@googlegroups.com

Gopher Robot submitted the change

Change information

Commit message:
cmd/compile: allow halt flag to run concurrently

During the investigation for #78081, I found it helpful to use the -h
flag to get a compiler core dump. I don't see any reason why it would
need to clamp concurrency down. We have pretty good support for not
interleaving log lines and if people really need it, they can always
pass -c=1.
Change-Id: Ic6425fc0da63e7ac42e0821f3d40ec4c6a6a6964
Reviewed-by: Cherry Mui <cher...@google.com>
Auto-Submit: Daniel Morsing <daniel....@gmail.com>
Reviewed-by: Robert Griesemer <g...@google.com>
Files:
  • M src/cmd/compile/internal/base/flag.go
Change size: XS
Delta: 1 file changed, 0 insertions(+), 1 deletion(-)
Branch: refs/heads/master
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Cherry Mui, +2 by Robert Griesemer
  • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Ic6425fc0da63e7ac42e0821f3d40ec4c6a6a6964
Gerrit-Change-Number: 756321
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Morsing <daniel....@gmail.com>
Gerrit-Reviewer: Cherry Mui <cher...@google.com>
Gerrit-Reviewer: Daniel Morsing <daniel....@gmail.com>
Gerrit-Reviewer: David Chase <drc...@google.com>
Gerrit-Reviewer: Gopher Robot <go...@golang.org>
Gerrit-Reviewer: Keith Randall <k...@golang.org>
Gerrit-Reviewer: Martin Möhrmann <moeh...@google.com>
Gerrit-Reviewer: Robert Griesemer <g...@golang.org>
Gerrit-Reviewer: Robert Griesemer <g...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages