[go] internal/runtime/atomic: fix missing linknames
0 views
Skip to first unread message
Gopher Robot (Gerrit)
May 17, 2024, 4:08:47 PMMay 17
to Austin Clements, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Go LUCI, Cherry Mui, David Chase, Mauri de Souza Meneguzzo, Keith Randall, Dmitri Shuralyov, golang-co...@googlegroups.com
Gopher Robot submitted the change![]( "Open in Gerrit")
Change information
Commit message:
internal/runtime/atomic: fix missing linknames
CL 544455, which added atomic And/Or APIs, raced with CL 585556, which
enabled stricter linkname checking. This caused linkname-related
failures on ARM and MIPS. Fix this by adding the necessary linknames.
We fix one other linkname that got overlooked in CL 585556.
Updates #61395.
Change-Id: I454f0767ce28188e550a61bc39b7e398239bc10e
Reviewed-on: https://go-review.googlesource.com/c/go/+/586516
Reviewed-by: Mauri de Souza Meneguzzo <maur...@gmail.com>
Reviewed-by: Cherry Mui <cher...@google.com>
Reviewed-by: David Chase <drc...@google.com>
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Austin Clements <aus...@google.com>
Files:
- M src/internal/runtime/atomic/atomic_andor_generic.go
- M src/internal/runtime/atomic/atomic_mipsx.go
- M src/runtime/runtime2.go
Change size: S
Delta: 3 files changed, 17 insertions(+), 0 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +1 by Mauri de Souza Meneguzzo, +2 by David Chase, +2 by Cherry Mui
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages