[go] internal/runtime/atomic: fix missing linknames

Skip to first unread message

Gopher Robot (Gerrit)

May 17, 2024, 4:08:47 PMMay 17
to Austin Clements, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Go LUCI, Cherry Mui, David Chase, Mauri de Souza Meneguzzo, Keith Randall, Dmitri Shuralyov, golang-co...@googlegroups.com

Gopher Robot submitted the change

Change information

Commit message:
internal/runtime/atomic: fix missing linknames

CL 544455, which added atomic And/Or APIs, raced with CL 585556, which
enabled stricter linkname checking. This caused linkname-related
failures on ARM and MIPS. Fix this by adding the necessary linknames.

We fix one other linkname that got overlooked in CL 585556.

Updates #61395.
Change-Id: I454f0767ce28188e550a61bc39b7e398239bc10e
Reviewed-by: Mauri de Souza Meneguzzo <maur...@gmail.com>
Reviewed-by: Cherry Mui <cher...@google.com>
Reviewed-by: David Chase <drc...@google.com>
Auto-Submit: Austin Clements <aus...@google.com>
  • M src/internal/runtime/atomic/atomic_andor_generic.go
  • M src/internal/runtime/atomic/atomic_mipsx.go
  • M src/runtime/runtime2.go
Change size: S
Delta: 3 files changed, 17 insertions(+), 0 deletions(-)
Branch: refs/heads/master
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Mauri de Souza Meneguzzo, +2 by David Chase, +2 by Cherry Mui
  • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I454f0767ce28188e550a61bc39b7e398239bc10e
Gerrit-Change-Number: 586516
Gerrit-PatchSet: 3
Gerrit-Owner: Austin Clements <aus...@google.com>
Gerrit-Reviewer: Austin Clements <aus...@google.com>
Gerrit-Reviewer: Cherry Mui <cher...@google.com>
Gerrit-Reviewer: David Chase <drc...@google.com>
Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org>
Gerrit-Reviewer: Gopher Robot <go...@golang.org>
Gerrit-Reviewer: Keith Randall <k...@google.com>
Gerrit-Reviewer: Mauri de Souza Meneguzzo <maur...@gmail.com>
Reply all
Reply to author
0 new messages