[go] cmd/go: disallow net in script tests

0 views

Skip to first unread message

Michael Matloob (Gerrit)

unread,

4:31 PM (2 hours ago) 4:31 PM

to Michael Matloob, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, golang...@luci-project-accounts.iam.gserviceaccount.com, Dmitri Shuralyov, Dmitri Shuralyov, golang-co...@googlegroups.com

Michael Matloob submitted the change

Unreviewed changes

4 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:

cmd/go: remove net script test condition from main go command suite

This effectively removes the ability to make external network connection
from scripttest suites.

Fixes #80243

Change-Id: Id90d0333176384ed69ada5bf774ac53d6a6a6964

Reviewed-on: https://go-review.googlesource.com/c/go/+/796380

Reviewed-by: Michael Matloob <mat...@golang.org>

Reviewed-by: Dmitri Shuralyov <dmit...@golang.org>

Reviewed-by: Dmitri Shuralyov <dmit...@google.com>

LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>

Reviewed-by: Funda Secgin <fundas...@gmail.com>

Reviewed-by: Michael Matloob <mat...@google.com>

Files:

M src/cmd/go/scriptconds_test.go
M src/cmd/go/testdata/script/README

Change size: S

Delta: 2 files changed, 0 insertions(+), 41 deletions(-)

Branch: refs/heads/master

Submit Requirements:

Code-Review: +1 by Michael Matloob, +1 by Dmitri Shuralyov, +2 by Dmitri Shuralyov, +1 by Funda Secgin
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages