[go] cmd/asm: on PPC64, fix assembling of FCMPO opcode

Skip to first unread message

Paul Murphy (Gerrit)

May 17, 2024, 5:53:57 PMMay 17
to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Go LUCI, Cherry Mui, Dmitri Shuralyov, Dmitri Shuralyov, Lynn Boger, Jayanth Krishnamurthy, golang-co...@googlegroups.com

Paul Murphy submitted the change with unreviewed changes

Unreviewed changes

1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

The name of the file: src/cmd/asm/internal/asm/testdata/ppc64.s
Insertions: 1, Deletions: 1.

The diff is too large to show. Please review the diff.

Change information

Commit message:
cmd/asm: on PPC64, fix assembling of FCMPO opcode

The assembler should pack 3 argument usage of FCMPO similar
to other CMP-like opcodes.

Fixes #67359
Change-Id: Icfb42a67d741431a70dd880806857b4c38f42d62
Reviewed-by: Cherry Mui <cher...@google.com>
Reviewed-by: Lynn Boger <lab...@linux.vnet.ibm.com>
Reviewed-by: Dmitri Shuralyov <dmit...@google.com>
  • M src/cmd/asm/internal/arch/ppc64.go
  • M src/cmd/asm/internal/asm/testdata/ppc64.s
Change size: XS
Delta: 2 files changed, 4 insertions(+), 1 deletion(-)
Branch: refs/heads/master
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Dmitri Shuralyov, +2 by Lynn Boger, +1 by Cherry Mui
  • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Icfb42a67d741431a70dd880806857b4c38f42d62
Gerrit-Change-Number: 585640
Gerrit-PatchSet: 5
Gerrit-Owner: Paul Murphy <mu...@ibm.com>
Gerrit-Reviewer: Cherry Mui <cher...@google.com>
Gerrit-Reviewer: Dmitri Shuralyov <dmit...@google.com>
Gerrit-Reviewer: Lynn Boger <lab...@linux.vnet.ibm.com>
Gerrit-Reviewer: Paul Murphy <mu...@ibm.com>
Gerrit-CC: Dmitri Shuralyov <dmit...@golang.org>
Gerrit-CC: Jayanth Krishnamurthy <jayanth.kr...@ibm.com>
Reply all
Reply to author
0 new messages