[go] cmd/asm/internal/asm: abort end to end test if assembly failed
1 view
Skip to first unread message
Gopher Robot (Gerrit)
Dec 23, 2025, 1:45:49 PM (2 days ago) Dec 23
to Joel Sing, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Michael Knyszek, Go LUCI, Cherry Mui, golang-co...@googlegroups.com
Gopher Robot submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: src/cmd/asm/internal/asm/endtoend_test.go
Insertions: 1, Deletions: 1.
@@ -201,7 +201,7 @@
if !ok {
// If we've encountered errors, the output is unlikely to be sane.
- return
+ t.FailNow()
}
for p := top; p != nil; p = p.Link {
```
Change information
Commit message:
cmd/asm/internal/asm: abort end to end test if assembly failed
If errors are encountered during assembly, do not attempt to perform verification.
In this case the output is unlikely to be correct and all verification fails, which
means the real issue gets lost in the noise.
Change-Id: I62c1bf09fa025b0df4c06f0bfa424fb5d328184b
Reviewed-on: https://go-review.googlesource.com/c/go/+/731920
Reviewed-by: Cherry Mui <cher...@google.com>
Auto-Submit: Joel Sing <jo...@sing.id.au>
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Knyszek <mkny...@google.com>
Files:
- M src/cmd/asm/internal/asm/endtoend_test.go
Change size: XS
Delta: 1 file changed, 5 insertions(+), 0 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +2 by Cherry Mui, +0 by Joel Sing, +1 by Michael Knyszek
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages