[go] sync/atomic: correct Uintptr.Or return doc

0 views
Skip to first unread message

Gopher Robot (Gerrit)

unread,
Sep 25, 2025, 1:29:47 PM (6 days ago) Sep 25
to Michael Pratt, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Go LUCI, Mauri de Souza Meneguzzo, Michael Knyszek, golang-co...@googlegroups.com

Gopher Robot submitted the change

Change information

Commit message:
sync/atomic: correct Uintptr.Or return doc

Uintptr.Or returns the old value, just like all of the other Or
functions. This was a typo in the original CL 544455.

Fixes #75607.
Change-Id: I260959e7e32e51f1152b5271df6cc51adfa02a4d
Reviewed-by: Michael Knyszek <mkny...@google.com>
Reviewed-by: Mauri de Souza Meneguzzo <maur...@gmail.com>
Auto-Submit: Michael Pratt <mpr...@google.com>
Files:
  • M src/sync/atomic/type.go
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/master
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by Michael Knyszek, +1 by Mauri de Souza Meneguzzo
  • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I260959e7e32e51f1152b5271df6cc51adfa02a4d
Gerrit-Change-Number: 706816
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Pratt <mpr...@google.com>
Gerrit-Reviewer: Gopher Robot <go...@golang.org>
Gerrit-Reviewer: Mauri de Souza Meneguzzo <maur...@gmail.com>
Gerrit-Reviewer: Michael Knyszek <mkny...@google.com>
Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
open
diffy
satisfied_requirement

Carlos Amedee (Gerrit)

unread,
12:40 PM (10 hours ago) 12:40 PM
to Michael Pratt, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Michael Knyszek, Go LUCI, golang-co...@googlegroups.com

Carlos Amedee submitted the change

Change information

Commit message:
[release-branch.go1.24] sync/atomic: correct Uintptr.Or return doc


Uintptr.Or returns the old value, just like all of the other Or
functions. This was a typo in the original CL 544455.

For #75607.
Fixes #75609.


Change-Id: I260959e7e32e51f1152b5271df6cc51adfa02a4d
Reviewed-on: https://go-review.googlesource.com/c/go/+/706816
Reviewed-by: Michael Knyszek <mkny...@google.com>
Reviewed-by: Mauri de Souza Meneguzzo <maur...@gmail.com>
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Michael Pratt <mpr...@google.com>
(cherry picked from commit d70ad4e740e24b4b76961c4b56d698fa23668aa2)
Reviewed-on: https://go-review.googlesource.com/c/go/+/706855
Reviewed-by: Carlos Amedee <car...@golang.org>
Files:
  • M src/sync/atomic/type.go
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/release-branch.go1.24
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by Michael Knyszek, +1 by Carlos Amedee
  • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: go
Gerrit-Branch: release-branch.go1.24
Gerrit-Change-Id: I260959e7e32e51f1152b5271df6cc51adfa02a4d
Gerrit-Change-Number: 706855
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Pratt <mpr...@google.com>
Gerrit-Reviewer: Carlos Amedee <car...@golang.org>
open
diffy
satisfied_requirement

Carlos Amedee (Gerrit)

unread,
12:40 PM (10 hours ago) 12:40 PM
to Michael Pratt, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Go LUCI, Michael Knyszek, golang-co...@googlegroups.com

Carlos Amedee submitted the change

Change information

Commit message:
[release-branch.go1.25] sync/atomic: correct Uintptr.Or return doc


Uintptr.Or returns the old value, just like all of the other Or
functions. This was a typo in the original CL 544455.

For #75607.
Fixes #75610.


Change-Id: I260959e7e32e51f1152b5271df6cc51adfa02a4d
Reviewed-on: https://go-review.googlesource.com/c/go/+/706816
Reviewed-by: Michael Knyszek <mkny...@google.com>
Reviewed-by: Mauri de Souza Meneguzzo <maur...@gmail.com>
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Michael Pratt <mpr...@google.com>
(cherry picked from commit d70ad4e740e24b4b76961c4b56d698fa23668aa2)
Files:
  • M src/sync/atomic/type.go
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/release-branch.go1.25
Submit Requirements:
    • requirement satisfiedCode-Review: +2 by Michael Knyszek
    • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: go
    Gerrit-Branch: release-branch.go1.25
    Gerrit-Change-Id: I260959e7e32e51f1152b5271df6cc51adfa02a4d
    Gerrit-Change-Number: 706856
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages