[protobuf] compiler/protogen: introduce and expose feature resoluton to protogen

[Michael Stapelberg (Gerrit)]

Michael Stapelberg submitted the change

Change information

Commit message:

compiler/protogen: introduce and expose feature resoluton to protogen

This will allow go plugins to specify any custom extensions they care about using protoc to generate a FeatureSetDefaults object.  They can then access all ResolvedFeatures of any descriptors to do more involved codegen for languages outside of go.

Change-Id: I3be49645612c6712a9e58ba65b6374735f8197b8

Reviewed-on: https://go-review.googlesource.com/c/protobuf/+/729461

Reviewed-by: Lasse Folger <lasse...@google.com>

Reviewed-by: Michael Stapelberg <stape...@google.com>

LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Files:

• A cmd/protoc-gen-go/feature_resolution_test/feature_resolution_test.go
• A cmd/protoc-gen-go/feature_resolution_test/test_features_defaults.binpb
• A cmd/protoc-gen-go/testdata/featureresolution/basic.pb.go
• A cmd/protoc-gen-go/testdata/featureresolution/basic.proto
• A cmd/protoc-gen-go/testdata/features/test_features.pb.go
• A cmd/protoc-gen-go/testdata/features/test_features.proto
• M cmd/protoc-gen-go/testdata/gen_test.go
• M compiler/protogen/protogen.go
• M internal/cmd/generate-protos/main.go

Change size: XL

Delta: 9 files changed, 1916 insertions(+), 49 deletions(-)

Branch: refs/heads/master

Submit Requirements:

• Code-Review: +1 by Lasse Folger, +2 by Michael Stapelberg
• TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: protobuf

Gerrit-Branch: master

Gerrit-Change-Id: I3be49645612c6712a9e58ba65b6374735f8197b8

Gerrit-Change-Number: 729461

Gerrit-PatchSet: 3

Gerrit-Owner: Mike Kruskal <mkru...@google.com>

Gerrit-Reviewer: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Lasse Folger <lasse...@google.com>

Gerrit-Reviewer: Michael Stapelberg <stape...@google.com>