[go] encoding/json/v2: make Deterministic doc more approachable

0 views

Skip to first unread message

Michael Pratt (Gerrit)

unread,

Aug 6, 2026, 2:51:56 PM (4 days ago) Aug 6

to Michael Pratt, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, golang...@luci-project-accounts.iam.gserviceaccount.com, Joseph Tsai, Jonathan Amsterdam, Damien Neil, golang-co...@googlegroups.com

Michael Pratt submitted the change with unreviewed changes

Unreviewed changes

3 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: src/encoding/json/v2/options.go
Insertions: 4, Deletions: 3.

@@ -136,9 +136,10 @@
 //
 // For example, Go maps are marshaled sorted by key.
 //
-// Determinism is guaranteed across different instances of identical binaries,
-// but not across different builds of a program (such as different source or
-// toolchain version, different GOOS/GOARCH, different build flags).
+// For native Go types, Determinism is guaranteed across different instances of
+// identical binaries, but not across different builds of a program (such as
+// different source or toolchain version, different GOOS/GOARCH, different
+// build flags).
 //
 // This only affects marshaling and is ignored when unmarshaling.
 func Deterministic(v bool) Options {
```

Change information

Commit message:

encoding/json/v2: make Deterministic doc more approachable

This is an attempt to be more clear with what we are guaranteeing.

For #71497.

Change-Id: I3f3ab6a83a907d5700c14cf50f3d202d6a6a6964

Reviewed-on: https://go-review.googlesource.com/c/go/+/809760

Reviewed-by: Joseph Tsai <joe...@digital-static.net>

LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>

Reviewed-by: Jonathan Amsterdam <j...@google.com>

Files:

M src/encoding/json/v2/options.go

Change size: S

Delta: 1 file changed, 9 insertions(+), 5 deletions(-)

Branch: refs/heads/master

Submit Requirements:

Code-Review: +2 by Jonathan Amsterdam, +2 by Joseph Tsai
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages