[build] internal/diff: apply minmax fix
0 views
Skip to first unread message
Gopher Robot (Gerrit)
Feb 9, 2026, 6:10:26 PMFeb 9
to Dmitri Shuralyov, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Go LUCI, Alan Donovan, Dmitri Shuralyov, Carlos Amedee, golang-co...@googlegroups.com
Gopher Robot submitted the change![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
internal/diff: apply minmax fix
It turns out there weren't many places in x/build to apply this.
At this point, with the go directive still at go 1.24.9 in this module,
'go fix ./...' produces zero diff and exit code 0.
Note that the waitgroup analyzer will migrate us to sync.WaitGroup.Go,
but only after the module's go directive is updated to go 1.25.0.
Fixes golang/go#77519.
[git-generate]
go fix -minmax ./...
Change-Id: I592d927906384621ee43c49dc761cce6159a0c76
Reviewed-on: https://go-review.googlesource.com/c/build/+/743495
Auto-Submit: Dmitri Shuralyov <dmit...@golang.org>
Reviewed-by: Alan Donovan <adon...@google.com>
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmit...@google.com>
Files:
- M internal/diff/diff.go
Change size: XS
Delta: 1 file changed, 1 insertion(+), 4 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +2 by Alan Donovan, +1 by Dmitri Shuralyov
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages