[crypto] chacha20poly1305: panic on dst and additionalData overlap
0 views
Skip to first unread message
Sean Liao (Gerrit)
Oct 22, 2025, 9:37:29 PM (12 hours ago) Oct 22
to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, David Chase, Roland Shoemaker, Daniel McCarney, Gopher Robot, Go LUCI, golang-co...@googlegroups.com
Sean Liao submitted the change![]( "Open in Gerrit")
Change information
Commit message:
chacha20poly1305: panic on dst and additionalData overlap
The cipher.AEAD interface specifies that these should not overlap.
This mirrors the check that the GCM implementation does.
Fixes golang/go#75968
Updates golang/go#21624
Change-Id: If5fbb8611ff6c0aae44d50079bad29f56ce00f5b
Reviewed-on: https://go-review.googlesource.com/c/crypto/+/712860
Reviewed-by: Roland Shoemaker <rol...@golang.org>
Reviewed-by: David Chase <drc...@google.com>
Reviewed-by: Daniel McCarney <dan...@binaryparadox.net>
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Files:
- M chacha20poly1305/chacha20poly1305_amd64.go
- M chacha20poly1305/chacha20poly1305_generic.go
Change size: S
Delta: 2 files changed, 16 insertions(+), 4 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +2 by Daniel McCarney, +1 by David Chase, +2 by Roland Shoemaker
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages