[go/release-branch.go1.25] [release-branch.go1.25] test/fixedbugs: remove issue46234 test timeout

0 views
Skip to first unread message

Gopher Robot (Gerrit)

unread,
3:44 PM (7 hours ago) 3:44 PM
to Quim Muntal, Dmitri Shuralyov, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Dmitri Shuralyov, Carlos Amedee, David Chase, Go LUCI, golang-co...@googlegroups.com

Gopher Robot submitted the change

Change information

Commit message:
[release-branch.go1.25] test/fixedbugs: remove issue46234 test timeout

issue46234 is flaky on slow machines due to the possibility of running
into the constant timeout. Delete it in favor of timeouts applied at a
higher level.

Note that that test timeout already got increased from 30s to 45s in
CL 382774, but it was still not enough.

For #50973.
Fixes #78318.

Cq-Include-Trybots: luci.golang.try:go1.25-darwin-amd64_15,go1.25-darwin-amd64_14
Change-Id: I809249a05c6ca65fb6c44375c8de5758f21dbb91
Reviewed-on: https://go-review.googlesource.com/c/go/+/747520
Auto-Submit: Quim Muntal <quimm...@gmail.com>
Reviewed-by: Cherry Mui <cher...@google.com>
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmit...@golang.org>
Reviewed-by: Dmitri Shuralyov <dmit...@google.com>
(cherry picked from commit b0057a4e0cacb4c920c9eb82216b63ed60d6e9fb)
Reviewed-on: https://go-review.googlesource.com/c/go/+/758641
Auto-Submit: Dmitri Shuralyov <dmit...@google.com>
Reviewed-by: David Chase <drc...@google.com>
Files:
  • M test/fixedbugs/issue46234.go
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/release-branch.go1.25
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by David Chase, +1 by Dmitri Shuralyov
  • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: go
Gerrit-Branch: release-branch.go1.25
Gerrit-Change-Id: I809249a05c6ca65fb6c44375c8de5758f21dbb91
Gerrit-Change-Number: 758641
Gerrit-PatchSet: 2
Gerrit-Owner: Dmitri Shuralyov <dmit...@golang.org>
Gerrit-Reviewer: David Chase <drc...@google.com>
Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org>
Gerrit-Reviewer: Dmitri Shuralyov <dmit...@google.com>
Gerrit-Reviewer: Gopher Robot <go...@golang.org>
Gerrit-CC: Carlos Amedee <car...@golang.org>
Gerrit-CC: Quim Muntal <quimm...@gmail.com>
open
diffy
satisfied_requirement

Gopher Robot (Gerrit)

unread,
3:46 PM (7 hours ago) 3:46 PM
to Quim Muntal, Dmitri Shuralyov, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Dmitri Shuralyov, Carlos Amedee, David Chase, Go LUCI, golang-co...@googlegroups.com

Gopher Robot submitted the change

Change information

Commit message:
[release-branch.go1.26] test/fixedbugs: remove issue46234 test timeout


issue46234 is flaky on slow machines due to the possibility of running
into the constant timeout. Delete it in favor of timeouts applied at a
higher level.

Note that that test timeout already got increased from 30s to 45s in
CL 382774, but it was still not enough.

For #50973.
Fixes #78319.

Cq-Include-Trybots: luci.golang.try:go1.26-darwin-amd64_15,go1.26-darwin-amd64_14

Change-Id: I809249a05c6ca65fb6c44375c8de5758f21dbb91
Reviewed-on: https://go-review.googlesource.com/c/go/+/747520
Auto-Submit: Quim Muntal <quimm...@gmail.com>
Reviewed-by: Cherry Mui <cher...@google.com>
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Dmitri Shuralyov <dmit...@golang.org>
Reviewed-by: Dmitri Shuralyov <dmit...@google.com>
(cherry picked from commit b0057a4e0cacb4c920c9eb82216b63ed60d6e9fb)
Reviewed-on: https://go-review.googlesource.com/c/go/+/758640
Reviewed-by: David Chase <drc...@google.com>
Auto-Submit: Dmitri Shuralyov <dmit...@google.com>
TryBot-Bypass: Dmitri Shuralyov <dmit...@golang.org>
Files:
  • M test/fixedbugs/issue46234.go
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/release-branch.go1.26
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Dmitri Shuralyov, +2 by David Chase
  • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result-1 by Go LUCI, TryBot-Bypass+1 by Dmitri Shuralyov
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: go
Gerrit-Branch: release-branch.go1.26
Gerrit-Change-Id: I809249a05c6ca65fb6c44375c8de5758f21dbb91
Gerrit-Change-Number: 758640
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages