[go] crypto/tls: implement -expect-extended-master-secret in bogo shim

0 views

Skip to first unread message

Daniel McCarney (Gerrit)

unread,

Aug 6, 2026, 9:58:13 AM (4 days ago) Aug 6

to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, David Chase, golang...@luci-project-accounts.iam.gserviceaccount.com, Roland Shoemaker, Filippo Valsorda, golang-co...@googlegroups.com

Daniel McCarney submitted the change

Change information

Commit message:

crypto/tls: implement -expect-extended-master-secret in bogo shim

The runner passes this flag for tests that expect Extended Master
Secret to be negotiated, including all the positive ExtendedMasterSecret
tests and the YesToYes resumption tests, which were previously skipped
as unimplemented. Following BoringSSL, EMS is reported as always
negotiated in TLS 1.3, where the extension is irrelevant.

Pin the newly running tests in TestBogoSuite, and extend
TestBogoSuiteFIPSEMS to check that EMS handshakes and resumptions are
unaffected by both FIPS 140-3 enforcement and fips140ems=0.

Updates #80516

Change-Id: I14aaa1790f480a46e8d8dfd449a281ae395383ee

Reviewed-on: https://go-review.googlesource.com/c/go/+/805560

Reviewed-by: Roland Shoemaker <rol...@golang.org>

LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>

Reviewed-by: David Chase <drc...@google.com>

Files:

M src/crypto/tls/bogo_shim_test.go

Change size: S

Delta: 1 file changed, 29 insertions(+), 0 deletions(-)

Branch: refs/heads/master

Submit Requirements:

Code-Review: +1 by David Chase, +2 by Roland Shoemaker
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages