[tools] go/analysis/passes/modernize: drop -test from usage example

1 view
Skip to first unread message

Gopher Robot (Gerrit)

unread,
Sep 30, 2025, 4:47:52 PM (yesterday) Sep 30
to Kirill Kolyshkin, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Robert Findley, Go LUCI, Alan Donovan, Michael Matloob, golang-co...@googlegroups.com

Gopher Robot submitted the change

Change information

Commit message:
inline, modernize: drop -test, add -fix

The -test flag defaults to true for these tools, so it makes little
sense to have it explicitly specified.

This also adds missing -fix flag to commands where it is implied.

This also fixes the `go run` command for gofix, which was moved to a
new URL in CL 662755, and then moved again (and renamed to inline)
in CL 706899. Note the new URL is not working yet since there is no
release published with CL 706899 included (yet).
Change-Id: I33b6ec3568e7d634a2b575fd0bc1722b4de52e2b
Auto-Submit: Alan Donovan <adon...@google.com>
Auto-Submit: Kirill Kolyshkin <koly...@gmail.com>
Reviewed-by: Alan Donovan <adon...@google.com>
Reviewed-by: Robert Findley <rfin...@google.com>
Files:
  • M go/analysis/passes/inline/cmd/inline/main.go
  • M go/analysis/passes/inline/doc.go
  • M go/analysis/passes/modernize/doc.go
  • M gopls/doc/analyzers.md
  • M gopls/doc/release/v0.18.0.md
  • M gopls/internal/doc/api.json
Change size: S
Delta: 6 files changed, 11 insertions(+), 11 deletions(-)
Branch: refs/heads/master
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by Alan Donovan, +1 by Robert Findley
  • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: tools
Gerrit-Branch: master
Gerrit-Change-Id: I33b6ec3568e7d634a2b575fd0bc1722b4de52e2b
Gerrit-Change-Number: 707877
Gerrit-PatchSet: 4
Gerrit-Owner: Kirill Kolyshkin <koly...@gmail.com>
Gerrit-Reviewer: Alan Donovan <adon...@google.com>
Gerrit-Reviewer: Gopher Robot <go...@golang.org>
Gerrit-Reviewer: Kirill Kolyshkin <koly...@gmail.com>
Gerrit-Reviewer: Robert Findley <rfin...@google.com>
Gerrit-CC: Michael Matloob <mat...@golang.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages