[go] internal/poll: optimize socket completion modes

[Quim Muntal (Gerrit)]

Quim Muntal submitted the change

Change information

Commit message:

internal/poll: optimize socket completion modes

FILE_SKIP_SET_EVENT_ON_HANDLE is always safe to use.
FILE_SKIP_COMPLETION_PORT_ON_SUCCESS is safe as long as the socket
is provided by an IFS provider.

While here, stop using the kindFileNet type, it doesn't provide any
value.

Fixes #77448

Change-Id: Ib3dc0d68c7ff57b6a1f15f017e60a092e4b87f46

Reviewed-on: https://go-review.googlesource.com/c/go/+/742281

Reviewed-by: Damien Neil <dn...@google.com>

Reviewed-by: Michael Pratt <mpr...@google.com>

LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Files:

• A src/internal/poll/export_windows_test.go
• M src/internal/poll/fd_windows.go
• M src/internal/poll/fd_windows_test.go
• M src/internal/syscall/windows/net_windows.go

Change size: M

Delta: 4 files changed, 81 insertions(+), 33 deletions(-)

Branch: refs/heads/master

Submit Requirements:

• Code-Review: +1 by Michael Pratt, +2 by Damien Neil
• TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: go

Gerrit-Branch: master

Gerrit-Change-Id: Ib3dc0d68c7ff57b6a1f15f017e60a092e4b87f46

Gerrit-Change-Number: 742281

Gerrit-PatchSet: 4

Gerrit-Owner: Quim Muntal <quimm...@gmail.com>

Gerrit-Reviewer: Alex Brainman <alex.b...@gmail.com>

Gerrit-Reviewer: Damien Neil <dn...@google.com>

Gerrit-Reviewer: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Michael Pratt <mpr...@google.com>

Gerrit-Reviewer: Quim Muntal <quimm...@gmail.com>