[go] runtime/cgo: fix setg_gcc call on aix/ppc64

0 views

Skip to first unread message

Quim Muntal (Gerrit)

unread,

Feb 24, 2026, 12:57:06 AM (yesterday) Feb 24

to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Mark Freeman, David Chase, Gopher Robot, Paul Murphy, Go LUCI, Cherry Mui, golang-co...@googlegroups.com

Quim Muntal submitted the change

Unreviewed changes

1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:

runtime/cgo: fix setg_gcc call on aix/ppc64

aix/ppc64 uses function descriptors instead of function pointers. CL 708235 assumed the latter, which caused a crash when calling setg_gcc.

Fix the call by dereferencing the function descriptor to get the entry
point and TOC.

Tested using gomote, as LUCI builders still don't support aix/ppc64.

Fixes #77753.

Change-Id: I6a0a6e971341f18f400c044f47b0daa42b93599e

Reviewed-on: https://go-review.googlesource.com/c/go/+/747960

Run-TryBot: Paul Murphy <paum...@redhat.com>

Reviewed-by: Paul Murphy <paum...@redhat.com>

TryBot-Result: Gopher Robot <go...@golang.org>

Reviewed-by: Mark Freeman <markf...@google.com>

LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Reviewed-by: David Chase <drc...@google.com>

Files:

M src/runtime/cgo/gcc_aix_ppc64.S

Change size: XS

Delta: 1 file changed, 4 insertions(+), 1 deletion(-)

Branch: refs/heads/master

Submit Requirements:

Code-Review: +2 by Paul Murphy, +1 by David Chase, +1 by Mark Freeman
Legacy-TryBots-Pass: TryBot-Result+1 by Gopher Robot, Run-TryBot+1 by Paul Murphy
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages