[tools] go/analysis/checker: make test hermetic
0 views
Skip to first unread message
Gopher Robot (Gerrit)
Oct 7, 2025, 3:56:05 PM (16 hours ago) Oct 7
to Alan Donovan, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Go LUCI, Michael Pratt, golang-co...@googlegroups.com
Gopher Robot submitted the change![]( "Open in Gerrit")
Change information
Commit message:
go/analysis/checker: make test hermetic
Before, it made assumptions about the set of packages in
the standard library, which is about to change, burdening
the person making that change with a spurious test failure.
(Every time I do this we get burned. When will I learn?)
Now, it uses a fake test data tree.
Change-Id: Ib15f08cd28b38cf47fbb997291998959a679eaa2
Reviewed-on: https://go-review.googlesource.com/c/tools/+/709955
Reviewed-by: Michael Pratt <mpr...@google.com>
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Auto-Submit: Alan Donovan <adon...@google.com>
Files:
- M go/analysis/checker/example_test.go
Change size: M
Delta: 1 file changed, 117 insertions(+), 63 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +2 by Michael Pratt
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages