[go] crypto/internal/fips140/edwards25519: fix zero coeff. skip optimization
0 views
Skip to first unread message
Gopher Robot (Gerrit)
Apr 9, 2026, 12:11:39 PM (15 hours ago) Apr 9
to Filippo Valsorda, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Junyang Shao, David Chase, Daniel McCarney, Go LUCI, Roland Shoemaker, golang-co...@googlegroups.com
Gopher Robot submitted the change![]( "Open in Gerrit")
Change information
Commit message:
crypto/internal/fips140/edwards25519: fix zero coeff. skip optimization
This was reported first by Adrian Grigore in private and then by
github.com/shaharcohen1 in FiloSottile/edwards25519#53.
fips140: off
goos: linux
goarch: amd64
pkg: crypto/internal/fips140/edwards25519
cpu: AMD EPYC 7443P 24-Core Processor
│ 6837583eec │ 6837583eec-dirty │
│ sec/op │ sec/op vs base │
VarTimeDoubleScalarBaseMult-48 43.51µ ± 1% 42.92µ ± 0% -1.34% (p=0.000 n=100)
Change-Id: I14523fc62732ae9233b8c198a3a626a36a6a6964
Reviewed-on: https://go-review.googlesource.com/c/go/+/745860
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Daniel McCarney <dan...@binaryparadox.net>
Reviewed-by: David Chase <drc...@google.com>
Auto-Submit: Filippo Valsorda <fil...@golang.org>
Reviewed-by: Junyang Shao <shaoj...@google.com>
Files:
- M src/crypto/internal/fips140/edwards25519/scalarmult.go
Change size: XS
Delta: 1 file changed, 3 insertions(+), 2 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +1 by Junyang Shao, +1 by David Chase, +2 by Daniel McCarney
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages