[go] cmd/go: refactor usage of `MainModules`

[Ian Alexander (Gerrit)]

Ian Alexander submitted the change

Unreviewed changes

5 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:

cmd/go: refactor usage of `MainModules`

This commit refactors usage of the global variable `MainModules` to
the global LoaderState variable of the same name.

This commit is part of the overall effort to eliminate global
modloader state.

[git-generate]
cd src/cmd/go/internal/modload
rf 'mv State.mainModules State.MainModules'
rf 'ex { MainModules -> LoaderState.MainModules }'
for dir in load modcmd modget test tool workcmd ; do
  cd ../${dir}
  rf 'ex {
    import "cmd/go/internal/modload"
    modload.MainModules -> modload.LoaderState.MainModules
  }'
done
cd ../modload
rf 'rm MainModules'

Change-Id: I15644c84190717d62ae953747a288ec6495ef168

Reviewed-on: https://go-review.googlesource.com/c/go/+/698060

Reviewed-by: Michael Matloob <mat...@golang.org>

Reviewed-by: Michael Matloob <mat...@google.com>

LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Files:

• M src/cmd/go/internal/load/godebug.go
• M src/cmd/go/internal/load/pkg.go
• M src/cmd/go/internal/load/search.go
• M src/cmd/go/internal/modcmd/download.go
• M src/cmd/go/internal/modcmd/vendor.go
• M src/cmd/go/internal/modcmd/verify.go
• M src/cmd/go/internal/modget/get.go
• M src/cmd/go/internal/modget/query.go
• M src/cmd/go/internal/modload/build.go
• M src/cmd/go/internal/modload/buildlist.go
• M src/cmd/go/internal/modload/edit.go
• M src/cmd/go/internal/modload/import.go
• M src/cmd/go/internal/modload/init.go
• M src/cmd/go/internal/modload/list.go
• M src/cmd/go/internal/modload/load.go
• M src/cmd/go/internal/modload/modfile.go
• M src/cmd/go/internal/modload/mvs.go
• M src/cmd/go/internal/modload/query.go
• M src/cmd/go/internal/modload/search.go
• M src/cmd/go/internal/modload/vendor.go
• M src/cmd/go/internal/test/test.go
• M src/cmd/go/internal/tool/tool.go
• M src/cmd/go/internal/workcmd/sync.go

Change size: L

Delta: 23 files changed, 182 insertions(+), 184 deletions(-)

Branch: refs/heads/master

Submit Requirements:

• Code-Review: +1 by Michael Matloob, +2 by Michael Matloob
• TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: go

Gerrit-Branch: master

Gerrit-Change-Id: I15644c84190717d62ae953747a288ec6495ef168

Gerrit-Change-Number: 698060

Gerrit-PatchSet: 12

Gerrit-Owner: Ian Alexander <ji...@google.com>

Gerrit-Reviewer: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Ian Alexander <ji...@google.com>

Gerrit-Reviewer: Michael Matloob <mat...@golang.org>

Gerrit-Reviewer: Michael Matloob <mat...@google.com>