[build/luci-config] main.star: downgrade to Node 13 on release-branch.go1.20
1 view
Skip to first unread message
Gopher Robot (Gerrit)
Oct 6, 2023, 4:53:26 PM10/6/23
to Dmitri Shuralyov, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Michael Knyszek, Heschi Kreinick, Dmitri Shuralyov
Gopher Robot submitted this change.
Approvals:
Dmitri Shuralyov: Looks good to me, but someone else must approve; Automatically submit change; Ignore missing or failing TryBot-Result
Michael Knyszek: Looks good to me, approved
main.star: downgrade to Node 13 on release-branch.go1.20
I thought it was Node 14 because of go.dev/cl/338730,
but it turns out the actual image still has Node 13.
To minimize new development work on release branches,
we're not going to do anything about that now.
For golang/go#61104.
Change-Id: I86d8f4ae4c1a5e0df6921326575141fa5338fc9f
Reviewed-on: https://go-review.googlesource.com/c/build/+/533264
Reviewed-by: Dmitri Shuralyov <dmit...@google.com>
TryBot-Bypass: Dmitri Shuralyov <dmit...@google.com>
Auto-Submit: Dmitri Shuralyov <dmit...@google.com>
Reviewed-by: Michael Knyszek <mkny...@google.com>
---
M generated/cr-buildbucket.cfg
M main.star
2 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/generated/cr-buildbucket.cfg b/generated/cr-buildbucket.cfg
index 63e85d9..8e934af 100644
--- a/generated/cr-buildbucket.cfg
+++ b/generated/cr-buildbucket.cfg
@@ -541,7 +541,7 @@
' "git_cache": "git",'
' "go_branch": "release-branch.go1.20",'
' "mode": 1,'
- ' "node_version": "14.14.0",'
+ ' "node_version": "13.2.0",'
' "project": "go",'
' "tools_cache": "tools"'
'}'
@@ -58284,7 +58284,7 @@
' "go_branch": "release-branch.go1.20",'
' "go_commit": "",'
' "mode": 2,'
- ' "node_version": "14.14.0",'
+ ' "node_version": "13.2.0",'
' "project": "go",'
' "tools_cache": "tools"'
'}'
@@ -58324,7 +58324,7 @@
' "go_branch": "release-branch.go1.20",'
' "go_commit": "",'
' "mode": 3,'
- ' "node_version": "14.14.0",'
+ ' "node_version": "13.2.0",'
' "project": "go",'
' "test_mode": {},'
' "test_shard": {'
@@ -67618,7 +67618,7 @@
' "git_cache": "git",'
' "go_branch": "release-branch.go1.20",'
' "mode": 1,'
- ' "node_version": "14.14.0",'
+ ' "node_version": "13.2.0",'
' "project": "go",'
' "tools_cache": "tools"'
'}'
@@ -71167,7 +71167,7 @@
' "go_branch": "release-branch.go1.20",'
' "go_commit": "",'
' "mode": 2,'
- ' "node_version": "14.14.0",'
+ ' "node_version": "13.2.0",'
' "project": "go",'
' "tools_cache": "tools"'
'}'
@@ -71207,7 +71207,7 @@
' "go_branch": "release-branch.go1.20",'
' "go_commit": "",'
' "mode": 3,'
- ' "node_version": "14.14.0",'
+ ' "node_version": "13.2.0",'
' "project": "go",'
' "test_mode": {},'
' "test_shard": {'
@@ -77165,7 +77165,7 @@
' "git_cache": "git",'
' "go_branch": "release-branch.go1.20",'
' "mode": 1,'
- ' "node_version": "14.14.0",'
+ ' "node_version": "13.2.0",'
' "project": "go",'
' "tools_cache": "tools"'
'}'
@@ -145986,7 +145986,7 @@
' "go_branch": "release-branch.go1.20",'
' "go_commit": "",'
' "mode": 2,'
- ' "node_version": "14.14.0",'
+ ' "node_version": "13.2.0",'
' "project": "go",'
' "tools_cache": "tools"'
'}'
@@ -146026,7 +146026,7 @@
' "go_branch": "release-branch.go1.20",'
' "go_commit": "",'
' "mode": 3,'
- ' "node_version": "14.14.0",'
+ ' "node_version": "13.2.0",'
' "project": "go",'
' "test_mode": {},'
' "test_shard": {'
diff --git a/main.star b/main.star
index ec25121..fffb26e 100755
--- a/main.star
+++ b/main.star
@@ -561,11 +561,11 @@
node_versions = {
# Confirm that version is available with: cipd search infra/3pp/tools/nodejs/linux-amd64 -tag=version:{node_version}
18: "2...@18.8.0",
- 14: "14.14.0",
+ 13: "13.2.0",
}
base_props["node_version"] = node_versions[18]
if go_branch_short == "go1.20":
- base_props["node_version"] = node_versions[14]
+ base_props["node_version"] = node_versions[13]
# Construct the basic dimensions for the build/test running part of the build.
#
To view, visit change 533264. To unsubscribe, or for help writing mail filters, visit settings.
Reply all
Reply to author
Forward
0 new messages