[tools] gopls/internal/protocol/semtok: add instructions for modifier changes
0 views
Skip to first unread message
Gopher Robot (Gerrit)
Aug 6, 2026, 1:24:18 PM (4 days ago) Aug 6
to Hongxiang Jiang, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, golang...@luci-project-accounts.iam.gserviceaccount.com, Alex Putman, golang-co...@googlegroups.com
Gopher Robot submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: gopls/internal/protocol/semtok/semtok.go
Insertions: 4, Deletions: 1.
@@ -44,6 +44,9 @@
//
// If you move types to above, document it in
// gopls/doc/features/passive.md#semantic-tokens.
+ //
+ // Sync any changes below with the vscode-go custom token type list.
+ // See: extension/src/language/goSemanticTokens.ts
// TokClass Type = "class"
// TokDecorator Type = "decorator"
// TokEnum Type = "enum"
@@ -104,7 +107,7 @@
// (e.g. a variable can have function type),
// we use modifiers for the top-level type constructor.
//
- // Sync any changes below with the vscode-go custom modifier list.
+ // Sync any changes below with the vscode-go custom token modifier list.
// See: extension/src/language/goSemanticTokens.ts
ModArray Modifier = "array"
ModBool Modifier = "bool"
```
Change information
Commit message:
gopls/internal/protocol/semtok: instructions for modifier/type changes
Gopls now honors the modifiers sent by the language client and only
returns modifiers if the language client supports them.
When gopls add / delete custom modifiers, the vscode-go should be
updated as well to keep in sync.
For golang/go#80736
Change-Id: Ib08d5a37f7e6ff8aceb1c06513b2da7f1d879303
Reviewed-on: https://go-review.googlesource.com/c/tools/+/811140
Auto-Submit: Hongxiang Jiang <hxj...@golang.org>
LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Alex Putman <apu...@golang.org>
Files:
- M gopls/internal/protocol/semtok/semtok.go
Change size: XS
Delta: 1 file changed, 6 insertions(+), 0 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +2 by Alex Putman
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages