[go] Always set the servers field to defaultNS

0 views
Skip to first unread message

Gopher Robot (Gerrit)

unread,
Feb 12, 2026, 3:05:57 PM (15 hours ago) Feb 12
to Mateusz Poliwczak, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Michael Pratt, Damien Neil, Junyang Shao, Go LUCI, Ian Lance Taylor, golang-co...@googlegroups.com

Gopher Robot submitted the change

Change information

Commit message:
net: always set the servers field to defaultNS

When the field is parsed from a file, it would never
have len(servers) == 0, lets enforce that and update
test cases where we had it wrong.
Change-Id: I7fa6ebcf63b9fe20fbbf791113ca948d6a6a6964
Auto-Submit: Michael Pratt <mpr...@google.com>
Reviewed-by: Junyang Shao <shaoj...@google.com>
Reviewed-by: Damien Neil <dn...@google.com>
Reviewed-by: Sean Liao <se...@liao.dev>
Files:
  • M src/net/conf_test.go
  • M src/net/dnsclient_unix.go
Change size: S
Delta: 2 files changed, 17 insertions(+), 7 deletions(-)
Branch: refs/heads/master
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Junyang Shao, +2 by Sean Liao, +2 by Damien Neil
  • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I7fa6ebcf63b9fe20fbbf791113ca948d6a6a6964
Gerrit-Change-Number: 743020
Gerrit-PatchSet: 3
Gerrit-Owner: Mateusz Poliwczak <mpoliw...@gmail.com>
Gerrit-Reviewer: Damien Neil <dn...@google.com>
Gerrit-Reviewer: Gopher Robot <go...@golang.org>
Gerrit-Reviewer: Ian Lance Taylor <ia...@golang.org>
Gerrit-Reviewer: Junyang Shao <shaoj...@google.com>
Gerrit-Reviewer: Mateusz Poliwczak <mpoliw...@gmail.com>
Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
Gerrit-Reviewer: Sean Liao <se...@liao.dev>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages