[go/release-branch.go1.26] [release-branch.go1.26] cmd/compile: keep blank nodes alive in b.loop

1 view

Skip to first unread message

Gopher Robot (Gerrit)

unread,

Apr 29, 2026, 5:07:33 PM (20 hours ago) Apr 29

to Junyang Shao, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, golang...@luci-project-accounts.iam.gserviceaccount.com, David Chase, Michael Pratt, Keith Randall, Cuong Le, golang-co...@googlegroups.com

Gopher Robot submitted the change

Change information

Commit message:

[release-branch.go1.26] cmd/compile: keep blank nodes alive in b.loop

The current bloop pass implementation skips blank nodes silently. This
CL makes it aware of that and keep them alive in temps.

For #77654.
Fixes #78155.

Change-Id: Iaffa5194ba1f0fe8d7c80a4c8e5c9a65a47bf534

Reviewed-on: https://go-review.googlesource.com/c/go/+/754920

LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Reviewed-by: Keith Randall <k...@google.com>

Reviewed-by: Cuong Manh Le <cuong.m...@gmail.com>

Reviewed-by: Keith Randall <k...@golang.org>

Reviewed-on: https://go-review.googlesource.com/c/go/+/772122

LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>

Reviewed-by: David Chase <drc...@google.com>

Auto-Submit: Junyang Shao <shaoj...@google.com>

Reviewed-by: Michael Pratt <mpr...@google.com>

Files:

M src/cmd/compile/internal/bloop/bloop.go
M test/bloop.go

Change size: M

Delta: 2 files changed, 51 insertions(+), 1 deletion(-)

Branch: refs/heads/release-branch.go1.26

Submit Requirements:

Code-Review: +2 by David Chase, +1 by Michael Pratt
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages