[go] runtime/secret: restore goroutine behavior to proposal

[David Chase (Gerrit)]

David Chase submitted the change

Change information

Commit message:

runtime/secret: restore goroutine behavior to proposal

During review of CL 704615, a suggestion was made that spawning a
goroutine inside a call to secret.Do result in a panic. I agreed with
this at the time, but had missed that this had been extensively
discussed on the proposal. Revert the behavior back to what was agreed
upon.

Change-Id: Ifaa9e24bd03ecbd870ae2217137d1a9527c96842

Reviewed-on: https://go-review.googlesource.com/c/go/+/728920

LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Reviewed-by: David Chase <drc...@google.com>

Reviewed-by: Roland Shoemaker <rol...@golang.org>

Files:

• M src/runtime/proc.go
• M src/runtime/secret/secret.go

Change size: XS

Delta: 2 files changed, 1 insertion(+), 5 deletions(-)

Branch: refs/heads/master

Submit Requirements:

• Code-Review: +1 by David Chase, +2 by Roland Shoemaker
• TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: go

Gerrit-Branch: master

Gerrit-Change-Id: Ifaa9e24bd03ecbd870ae2217137d1a9527c96842

Gerrit-Change-Number: 728920

Gerrit-PatchSet: 2

Gerrit-Owner: Daniel Morsing <daniel....@gmail.com>

Gerrit-Reviewer: Austin Clements <aus...@google.com>

Gerrit-Reviewer: David Chase <drc...@google.com>

Gerrit-Reviewer: Filippo Valsorda <fil...@golang.org>

Gerrit-Reviewer: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Roland Shoemaker <rol...@golang.org>

Gerrit-CC: Gopher Robot <go...@golang.org>