[go] cmd/go/testdata/script: don't use network in govcs script test

0 views

Skip to first unread message

Michael Matloob (Gerrit)

unread,

2:54 PM (4 hours ago) 2:54 PM

to Michael Matloob, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, golang...@luci-project-accounts.iam.gserviceaccount.com, Dmitri Shuralyov, Dmitri Shuralyov, golang-co...@googlegroups.com

Michael Matloob submitted the change

Unreviewed changes

2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:

cmd/go/testdata/script: don't use network in govcs script test

We can use one of the vcs-test git repos instead for the cases where
we actually try to access a git repo. The rest of the cases don't try to
go to VCS.

For #80243

Change-Id: I38d6f1f7fa28282fb036ca9dae0a53826a6a6964

Reviewed-on: https://go-review.googlesource.com/c/go/+/795900

LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>

Reviewed-by: Dmitri Shuralyov <dmit...@google.com>

Reviewed-by: Michael Matloob <mat...@google.com>

Reviewed-by: Dmitri Shuralyov <dmit...@golang.org>

Files:

M src/cmd/go/testdata/script/govcs.txt

Change size: XS

Delta: 1 file changed, 1 insertion(+), 1 deletion(-)

Branch: refs/heads/master

Submit Requirements:

Code-Review: +1 by Michael Matloob, +1 by Dmitri Shuralyov, +2 by Dmitri Shuralyov
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages