[pkgsite] internal: conditionally return documentation in GetUnit
0 views
Skip to first unread message
Gopher Robot (Gerrit)
1:16 PM (7 hours ago) 1:16 PM
to Ethan Lee, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Jonathan Amsterdam, kokoro, Go LUCI, golang-co...@googlegroups.com
Gopher Robot submitted the change![]( "Open in Gerrit")
Change information
Commit message:
internal: conditionally return documentation in GetUnit
- Large documentations blobs should avoid being returned unless
explicitly requested. Add a WithDocsSource to enable retrieval of
unit information without the large documentation source information.
- This does not functionally change existing GetUnit callsites.
Change-Id: Ie983b7eaeb61bb92f2716ae64a3d1e1ea738dbe2
Reviewed-by: Jonathan Amsterdam <j...@google.com>
kokoro-CI: kokoro <noreply...@google.com>
Auto-Submit: Ethan Lee <etha...@google.com>
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Files:
- M internal/api/api.go
- M internal/fetchdatasource/fetchdatasource_test.go
- M internal/frontend/main.go
- M internal/postgres/unit.go
- M internal/postgres/unit_test.go
- M internal/testing/fakedatasource/fakedatasource.go
- M internal/unit.go
- M internal/worker/fetch_test.go
- M internal/worker/fetcherror_test.go
- M internal/worker/refetch_test.go
Change size: M
Delta: 10 files changed, 44 insertions(+), 17 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +2 by Jonathan Amsterdam
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
kokoro-CI-Passes: kokoro-CI+1 by kokoro
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages