[telemetry] internal/crashmonitor: use the built-in min/max function

1 view
Skip to first unread message

Gopher Robot (Gerrit)

unread,
Sep 30, 2025, 11:24:46 AM (yesterday) Sep 30
to shuang cui, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Peter Weinberger, Michael Matloob, Robert Findley, Carlos Amedee, Go LUCI, golang-co...@googlegroups.com

Gopher Robot submitted the change

Change information

Commit message:
internal/crashmonitor: use the built-in min/max function

Starting from Go 1.21, the min/max functions are built-in.

Therefore, we can remove the custom functions with the same name.
Change-Id: I8548b4ead6c536c8da492c6fc3fb8fb71ce3c2e6
Auto-Submit: Sean Liao <se...@liao.dev>
Reviewed-by: Carlos Amedee <car...@golang.org>
Reviewed-by: Sean Liao <se...@liao.dev>
Reviewed-by: Peter Weinberger <p...@google.com>
Files:
  • M internal/crashmonitor/monitor.go
Change size: XS
Delta: 1 file changed, 0 insertions(+), 8 deletions(-)
Branch: refs/heads/master
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Carlos Amedee, +2 by Peter Weinberger, +2 by Sean Liao
  • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: telemetry
Gerrit-Branch: master
Gerrit-Change-Id: I8548b4ead6c536c8da492c6fc3fb8fb71ce3c2e6
Gerrit-Change-Number: 707515
Gerrit-PatchSet: 2
Gerrit-Owner: shuang cui <imc...@gmail.com>
Gerrit-Reviewer: Carlos Amedee <car...@golang.org>
Gerrit-Reviewer: Gopher Robot <go...@golang.org>
Gerrit-Reviewer: Michael Matloob <mat...@golang.org>
Gerrit-Reviewer: Peter Weinberger <p...@google.com>
Gerrit-Reviewer: Robert Findley <rfin...@google.com>
Gerrit-Reviewer: Sean Liao <se...@liao.dev>
Gerrit-Reviewer: shuang cui <imc...@gmail.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages