[go] runtime: guard unexpected return pc gp.m dereference

0 views
Skip to first unread message

Gopher Robot (Gerrit)

unread,
10:33 AM (3 hours ago) 10:33 AM
to Michael Pratt, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Go LUCI, Michael Knyszek, golang-co...@googlegroups.com

Gopher Robot submitted the change

Change information

Commit message:
runtime: guard unexpected return pc gp.m dereference

If stack scanning reaches here while scanning a waiting goroutine, gp.m
will be nil. We are going to crash anyway because the stack is corrupt,
but we still want to reach the print below for context rather than dying
with a SIGSEGV here.

For #64030.
Change-Id: I6a6a636c378669dc45972e1eb8e06401a0fed223
Auto-Submit: Michael Pratt <mpr...@google.com>
Reviewed-by: Michael Knyszek <mkny...@google.com>
Files:
  • M src/runtime/traceback.go
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/master
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by Michael Knyszek
  • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: I6a6a636c378669dc45972e1eb8e06401a0fed223
Gerrit-Change-Number: 726522
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Pratt <mpr...@google.com>
Gerrit-Reviewer: Gopher Robot <go...@golang.org>
Gerrit-Reviewer: Michael Knyszek <mkny...@google.com>
Gerrit-Reviewer: Michael Pratt <mpr...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages