[go] cmd/go/testdata/script: remove net check in get_iussue53955 test

0 views

Skip to first unread message

Michael Matloob (Gerrit)

unread,

2:54 PM (8 hours ago) 2:54 PM

to Michael Matloob, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, golang...@luci-project-accounts.iam.gserviceaccount.com, Dmitri Shuralyov, Dmitri Shuralyov, golang-co...@googlegroups.com

Michael Matloob submitted the change

Unreviewed changes

2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:

cmd/go/testdata/script: remove net check in get_issue53955 test

We don't actually go to the network here. The check says it's silenced
just in case, but if we're actually trying to go to github, we should
either fix the underlying problem, or migrate the test to use vcstest.

For #80243

Change-Id: Ib3c4786c96d5bb93c3b15ccd80bb497d6a6a6964

Reviewed-on: https://go-review.googlesource.com/c/go/+/795901

Reviewed-by: Dmitri Shuralyov <dmit...@golang.org>

LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>

Reviewed-by: Dmitri Shuralyov <dmit...@google.com>

Reviewed-by: Michael Matloob <mat...@google.com>

Files:

M src/cmd/go/testdata/script/get_issue53955.txt

Change size: XS

Delta: 1 file changed, 0 insertions(+), 1 deletion(-)

Branch: refs/heads/master

Submit Requirements:

Code-Review: +2 by Dmitri Shuralyov, +1 by Michael Matloob, +1 by Dmitri Shuralyov
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages