[go] cmd/compile: avoid panic in ternary rewrite on checked instructions

[David Chase (Gerrit)]

David Chase submitted the change

Change information

Commit message:

cmd/compile: avoid panic in ternary rewrite on checked instructions

The replace function in rewritetern.go was panicing when encountering
instructions that had already been processed. This adds a check to
ensure we don't trigger a panic on these instructions.

Fixes #77582

Change-Id: I0b38312109b9cedaa1cb1320015097d62588a2fe

Reviewed-on: https://go-review.googlesource.com/c/go/+/745460

LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Reviewed-by: David Chase <drc...@google.com>

Reviewed-by: Mark Freeman <markf...@google.com>

Files:

• A src/cmd/compile/internal/ssa/issue77582_test.go
• M src/cmd/compile/internal/ssa/rewritetern.go

Change size: S

Delta: 2 files changed, 32 insertions(+), 0 deletions(-)

Branch: refs/heads/master

Submit Requirements:

• Code-Review: +1 by Mark Freeman, +2 by David Chase
• TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: go

Gerrit-Branch: master

Gerrit-Change-Id: I0b38312109b9cedaa1cb1320015097d62588a2fe

Gerrit-Change-Number: 745460

Gerrit-PatchSet: 9

Gerrit-Owner: Eyal Cohen <yulu...@gmail.com>

Gerrit-Reviewer: David Chase <drc...@google.com>

Gerrit-Reviewer: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Mark Freeman <markf...@google.com>

Gerrit-CC: Gopher Robot <go...@golang.org>