[go] database/sql: use synctest in tests
0 views
Skip to first unread message
Gopher Robot (Gerrit)
4:32 PM (7 hours ago) 4:32 PM
to Damien Neil, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Go LUCI, Neal Patel, Jonathan Amsterdam, golang-co...@googlegroups.com
Gopher Robot submitted the change![]( "Open in Gerrit")
Unreviewed changes
4 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
database/sql: use synctest in tests
Replace various polling loops waiting for conditions to occur with
synctest-based synchronization. Replace fake time with synctest's
bubbled time.
Reduces time for "go test database/sql -count=10" from
~12s to ~0.5s on my M4 machine.
Change-Id: I7ea8d740d443e27c50df4d2f22aec6136a6a6964
Reviewed-on: https://go-review.googlesource.com/c/go/+/758065
Reviewed-by: Jonathan Amsterdam <j...@google.com>
Auto-Submit: Damien Neil <dn...@google.com>
Reviewed-by: Neal Patel <neal...@google.com>
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Files:
- M src/database/sql/sql.go
- M src/database/sql/sql_test.go
Change size: L
Delta: 2 files changed, 379 insertions(+), 215 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +2 by Neal Patel, +2 by Jonathan Amsterdam
TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages