[go] crypto/tls: quote protocols in ALPN error message

1 view
Skip to first unread message

Gopher Robot (Gerrit)

unread,
Sep 29, 2025, 2:28:23 PM (3 days ago) Sep 29
to Roland Shoemaker, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Nicholas Husin, Neal Patel, Nicholas Husin, Daniel McCarney, Go LUCI, golang-co...@googlegroups.com

Gopher Robot submitted the change

Change information

Commit message:
crypto/tls: quote protocols in ALPN error message

Quote the protocols sent by the client when returning the ALPN
negotiation error message.

Fixes CVE-2025-58189
Fixes #75652
Change-Id: Ie7b3a1ed0b6efcc1705b71f0f1e8417126661330
Auto-Submit: Roland Shoemaker <rol...@golang.org>
Reviewed-by: Neal Patel <neal...@google.com>
Reviewed-by: Nicholas Husin <n...@golang.org>
Auto-Submit: Nicholas Husin <n...@golang.org>
Reviewed-by: Nicholas Husin <hu...@google.com>
TryBot-Bypass: Roland Shoemaker <rol...@golang.org>
Reviewed-by: Daniel McCarney <dan...@binaryparadox.net>
Files:
  • M src/crypto/tls/handshake_server.go
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/master
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by Nicholas Husin, +1 by Nicholas Husin, +2 by Daniel McCarney, +1 by Neal Patel
  • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+0 by Go LUCI, TryBot-Bypass+1 by Roland Shoemaker
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: go
Gerrit-Branch: master
Gerrit-Change-Id: Ie7b3a1ed0b6efcc1705b71f0f1e8417126661330
Gerrit-Change-Number: 707776
Gerrit-PatchSet: 2
Gerrit-Owner: Roland Shoemaker <rol...@golang.org>
Gerrit-Reviewer: Daniel McCarney <dan...@binaryparadox.net>
Gerrit-Reviewer: Gopher Robot <go...@golang.org>
Gerrit-Reviewer: Neal Patel <neal...@google.com>
Gerrit-Reviewer: Nicholas Husin <hu...@google.com>
Gerrit-Reviewer: Nicholas Husin <n...@golang.org>
Gerrit-Reviewer: Roland Shoemaker <rol...@golang.org>
open
diffy
satisfied_requirement

Carlos Amedee (Gerrit)

unread,
Oct 1, 2025, 2:37:47 PM (14 hours ago) Oct 1
to Roland Shoemaker, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Go LUCI, golang-co...@googlegroups.com

Carlos Amedee submitted the change

Change information

Commit message:
[release-branch.go1.25] crypto/tls: quote protocols in ALPN error message


Quote the protocols sent by the client when returning the ALPN
negotiation error message.

Fixes CVE-2025-58189
Updates #75652
Fixes #75661


Change-Id: Ie7b3a1ed0b6efcc1705b71f0f1e8417126661330
Reviewed-on: https://go-review.googlesource.com/c/go/+/707776
Auto-Submit: Roland Shoemaker <rol...@golang.org>
Reviewed-by: Neal Patel <neal...@google.com>
Reviewed-by: Nicholas Husin <n...@golang.org>
Auto-Submit: Nicholas Husin <n...@golang.org>
Reviewed-by: Nicholas Husin <hu...@google.com>
TryBot-Bypass: Roland Shoemaker <rol...@golang.org>
Reviewed-by: Daniel McCarney <dan...@binaryparadox.net>
(cherry picked from commit 4e9006a716533fe1c7ee08df02dfc73078f7dc19)
Reviewed-on: https://go-review.googlesource.com/c/go/+/708095
Reviewed-by: Carlos Amedee <car...@golang.org>
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Files:
  • M src/crypto/tls/handshake_server.go
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/release-branch.go1.25
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by Carlos Amedee
  • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: go
Gerrit-Branch: release-branch.go1.25
Gerrit-Change-Id: Ie7b3a1ed0b6efcc1705b71f0f1e8417126661330
Gerrit-Change-Number: 708095
Gerrit-PatchSet: 2
Gerrit-Owner: Roland Shoemaker <rol...@golang.org>
Gerrit-Reviewer: Carlos Amedee <car...@golang.org>
Gerrit-Reviewer: Roland Shoemaker <rol...@golang.org>
open
diffy
satisfied_requirement

Carlos Amedee (Gerrit)

unread,
Oct 1, 2025, 2:37:51 PM (14 hours ago) Oct 1
to Roland Shoemaker, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Go LUCI, golang-co...@googlegroups.com

Carlos Amedee submitted the change

Change information

Commit message:
[release-branch.go1.24] crypto/tls: quote protocols in ALPN error message


Quote the protocols sent by the client when returning the ALPN
negotiation error message.

Fixes CVE-2025-58189
Updates #75652
Fixes #75660


Change-Id: Ie7b3a1ed0b6efcc1705b71f0f1e8417126661330
Reviewed-on: https://go-review.googlesource.com/c/go/+/707776
Auto-Submit: Roland Shoemaker <rol...@golang.org>
Reviewed-by: Neal Patel <neal...@google.com>
Reviewed-by: Nicholas Husin <n...@golang.org>
Auto-Submit: Nicholas Husin <n...@golang.org>
Reviewed-by: Nicholas Husin <hu...@google.com>
TryBot-Bypass: Roland Shoemaker <rol...@golang.org>
Reviewed-by: Daniel McCarney <dan...@binaryparadox.net>
(cherry picked from commit 4e9006a716533fe1c7ee08df02dfc73078f7dc19)
Files:
  • M src/crypto/tls/handshake_server.go
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/release-branch.go1.24
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by Carlos Amedee
  • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: go
Gerrit-Branch: release-branch.go1.24
Gerrit-Change-Id: Ie7b3a1ed0b6efcc1705b71f0f1e8417126661330
Gerrit-Change-Number: 708096
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages