[build/luci-config] main.star: fix syntax errors in luci build config
1 view
Skip to first unread message
Gopher Robot (Gerrit)
Mar 28, 2023, 1:10:08 PM3/28/23
to Yifan Yang, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Heschi Kreinick, Michael Knyszek, Carlos Amedee, Dmitri Shuralyov, golang-co...@googlegroups.com
Gopher Robot submitted this change.
Approvals:
Heschi Kreinick: Looks good to me, approved; Automatically submit change; Ignore missing or failing TryBot-Result
main.star: fix syntax errors in luci build config
The value for a environment variable specified in the builder
input properties seems to have to be a string.
See the below failure for more detail:
https://luci-milo.appspot.com/ui/p/golang/builders/ci/gotip-linux-amd64-longtest/b8785364441621028193/overview
Change-Id: I081883da2eef6c3fa28a60bb69849496c98403ab
Reviewed-on: https://go-review.googlesource.com/c/build/+/479630
Reviewed-by: Heschi Kreinick <hes...@google.com>
TryBot-Bypass: Heschi Kreinick <hes...@google.com>
Auto-Submit: Heschi Kreinick <hes...@google.com>
---
M generated/cr-buildbucket.cfg
M main.star
2 files changed, 50 insertions(+), 50 deletions(-)
diff --git a/generated/cr-buildbucket.cfg b/generated/cr-buildbucket.cfg
index 94e6bb0..77a1de2 100644
--- a/generated/cr-buildbucket.cfg
+++ b/generated/cr-buildbucket.cfg
@@ -37,8 +37,8 @@
properties:
'{'
' "env": {'
- ' "GO_TEST_SHORT": 0,'
- ' "GO_TEST_TIMEOUT_SCALE": 5'
+ ' "GO_TEST_SHORT": "0",'
+ ' "GO_TEST_TIMEOUT_SCALE": "5"'
' },'
' "go_branch": "release-branch.go1.20",'
' "project": "go"'
@@ -58,8 +58,8 @@
properties:
'{'
' "env": {'
- ' "GO_TEST_SHORT": 0,'
- ' "GO_TEST_TIMEOUT_SCALE": 5'
+ ' "GO_TEST_SHORT": "0",'
+ ' "GO_TEST_TIMEOUT_SCALE": "5"'
' },'
' "go_branch": "release-branch.go1.20",'
' "project": "go",'
@@ -115,8 +115,8 @@
properties:
'{'
' "env": {'
- ' "GO_TEST_SHORT": 0,'
- ' "GO_TEST_TIMEOUT_SCALE": 5'
+ ' "GO_TEST_SHORT": "0",'
+ ' "GO_TEST_TIMEOUT_SCALE": "5"'
' },'
' "go_branch": "release-branch.go1.20",'
' "project": "go"'
@@ -171,8 +171,8 @@
properties:
'{'
' "env": {'
- ' "GO_TEST_SHORT": 0,'
- ' "GO_TEST_TIMEOUT_SCALE": 5'
+ ' "GO_TEST_SHORT": "0",'
+ ' "GO_TEST_TIMEOUT_SCALE": "5"'
' },'
' "go_branch": "master",'
' "project": "go"'
@@ -192,8 +192,8 @@
properties:
'{'
' "env": {'
- ' "GO_TEST_SHORT": 0,'
- ' "GO_TEST_TIMEOUT_SCALE": 5'
+ ' "GO_TEST_SHORT": "0",'
+ ' "GO_TEST_TIMEOUT_SCALE": "5"'
' },'
' "go_branch": "master",'
' "project": "go",'
@@ -249,8 +249,8 @@
properties:
'{'
' "env": {'
- ' "GO_TEST_SHORT": 0,'
- ' "GO_TEST_TIMEOUT_SCALE": 5'
+ ' "GO_TEST_SHORT": "0",'
+ ' "GO_TEST_TIMEOUT_SCALE": "5"'
' },'
' "go_branch": "master",'
' "project": "go"'
@@ -305,8 +305,8 @@
properties:
'{'
' "env": {'
- ' "GO_TEST_SHORT": 0,'
- ' "GO_TEST_TIMEOUT_SCALE": 5'
+ ' "GO_TEST_SHORT": "0",'
+ ' "GO_TEST_TIMEOUT_SCALE": "5"'
' },'
' "go_branch": "release-branch.go1.20",'
' "project": "build"'
@@ -326,8 +326,8 @@
properties:
'{'
' "env": {'
- ' "GO_TEST_SHORT": 0,'
- ' "GO_TEST_TIMEOUT_SCALE": 5'
+ ' "GO_TEST_SHORT": "0",'
+ ' "GO_TEST_TIMEOUT_SCALE": "5"'
' },'
' "go_branch": "release-branch.go1.20",'
' "project": "build",'
@@ -383,8 +383,8 @@
properties:
'{'
' "env": {'
- ' "GO_TEST_SHORT": 0,'
- ' "GO_TEST_TIMEOUT_SCALE": 5'
+ ' "GO_TEST_SHORT": "0",'
+ ' "GO_TEST_TIMEOUT_SCALE": "5"'
' },'
' "go_branch": "release-branch.go1.20",'
' "project": "build"'
@@ -439,8 +439,8 @@
properties:
'{'
' "env": {'
- ' "GO_TEST_SHORT": 0,'
- ' "GO_TEST_TIMEOUT_SCALE": 5'
+ ' "GO_TEST_SHORT": "0",'
+ ' "GO_TEST_TIMEOUT_SCALE": "5"'
' },'
' "go_branch": "master",'
' "project": "build"'
@@ -460,8 +460,8 @@
properties:
'{'
' "env": {'
- ' "GO_TEST_SHORT": 0,'
- ' "GO_TEST_TIMEOUT_SCALE": 5'
+ ' "GO_TEST_SHORT": "0",'
+ ' "GO_TEST_TIMEOUT_SCALE": "5"'
' },'
' "go_branch": "master",'
' "project": "build",'
@@ -517,8 +517,8 @@
properties:
'{'
' "env": {'
- ' "GO_TEST_SHORT": 0,'
- ' "GO_TEST_TIMEOUT_SCALE": 5'
+ ' "GO_TEST_SHORT": "0",'
+ ' "GO_TEST_TIMEOUT_SCALE": "5"'
' },'
' "go_branch": "master",'
' "project": "build"'
@@ -573,8 +573,8 @@
properties:
'{'
' "env": {'
- ' "GO_TEST_SHORT": 0,'
- ' "GO_TEST_TIMEOUT_SCALE": 5'
+ ' "GO_TEST_SHORT": "0",'
+ ' "GO_TEST_TIMEOUT_SCALE": "5"'
' },'
' "go_branch": "release-branch.go1.20",'
' "project": "image"'
@@ -594,8 +594,8 @@
properties:
'{'
' "env": {'
- ' "GO_TEST_SHORT": 0,'
- ' "GO_TEST_TIMEOUT_SCALE": 5'
+ ' "GO_TEST_SHORT": "0",'
+ ' "GO_TEST_TIMEOUT_SCALE": "5"'
' },'
' "go_branch": "release-branch.go1.20",'
' "project": "image",'
@@ -651,8 +651,8 @@
properties:
'{'
' "env": {'
- ' "GO_TEST_SHORT": 0,'
- ' "GO_TEST_TIMEOUT_SCALE": 5'
+ ' "GO_TEST_SHORT": "0",'
+ ' "GO_TEST_TIMEOUT_SCALE": "5"'
' },'
' "go_branch": "release-branch.go1.20",'
' "project": "image"'
@@ -707,8 +707,8 @@
properties:
'{'
' "env": {'
- ' "GO_TEST_SHORT": 0,'
- ' "GO_TEST_TIMEOUT_SCALE": 5'
+ ' "GO_TEST_SHORT": "0",'
+ ' "GO_TEST_TIMEOUT_SCALE": "5"'
' },'
' "go_branch": "master",'
' "project": "image"'
@@ -728,8 +728,8 @@
properties:
'{'
' "env": {'
- ' "GO_TEST_SHORT": 0,'
- ' "GO_TEST_TIMEOUT_SCALE": 5'
+ ' "GO_TEST_SHORT": "0",'
+ ' "GO_TEST_TIMEOUT_SCALE": "5"'
' },'
' "go_branch": "master",'
' "project": "image",'
@@ -785,8 +785,8 @@
properties:
'{'
' "env": {'
- ' "GO_TEST_SHORT": 0,'
- ' "GO_TEST_TIMEOUT_SCALE": 5'
+ ' "GO_TEST_SHORT": "0",'
+ ' "GO_TEST_TIMEOUT_SCALE": "5"'
' },'
' "go_branch": "master",'
' "project": "image"'
@@ -841,8 +841,8 @@
properties:
'{'
' "env": {'
- ' "GO_TEST_SHORT": 0,'
- ' "GO_TEST_TIMEOUT_SCALE": 5'
+ ' "GO_TEST_SHORT": "0",'
+ ' "GO_TEST_TIMEOUT_SCALE": "5"'
' },'
' "go_branch": "release-branch.go1.20",'
' "project": "mod"'
@@ -862,8 +862,8 @@
properties:
'{'
' "env": {'
- ' "GO_TEST_SHORT": 0,'
- ' "GO_TEST_TIMEOUT_SCALE": 5'
+ ' "GO_TEST_SHORT": "0",'
+ ' "GO_TEST_TIMEOUT_SCALE": "5"'
' },'
' "go_branch": "release-branch.go1.20",'
' "project": "mod",'
@@ -919,8 +919,8 @@
properties:
'{'
' "env": {'
- ' "GO_TEST_SHORT": 0,'
- ' "GO_TEST_TIMEOUT_SCALE": 5'
+ ' "GO_TEST_SHORT": "0",'
+ ' "GO_TEST_TIMEOUT_SCALE": "5"'
' },'
' "go_branch": "release-branch.go1.20",'
' "project": "mod"'
@@ -975,8 +975,8 @@
properties:
'{'
' "env": {'
- ' "GO_TEST_SHORT": 0,'
- ' "GO_TEST_TIMEOUT_SCALE": 5'
+ ' "GO_TEST_SHORT": "0",'
+ ' "GO_TEST_TIMEOUT_SCALE": "5"'
' },'
' "go_branch": "master",'
' "project": "mod"'
@@ -996,8 +996,8 @@
properties:
'{'
' "env": {'
- ' "GO_TEST_SHORT": 0,'
- ' "GO_TEST_TIMEOUT_SCALE": 5'
+ ' "GO_TEST_SHORT": "0",'
+ ' "GO_TEST_TIMEOUT_SCALE": "5"'
' },'
' "go_branch": "master",'
' "project": "mod",'
@@ -1053,8 +1053,8 @@
properties:
'{'
' "env": {'
- ' "GO_TEST_SHORT": 0,'
- ' "GO_TEST_TIMEOUT_SCALE": 5'
+ ' "GO_TEST_SHORT": "0",'
+ ' "GO_TEST_TIMEOUT_SCALE": "5"'
' },'
' "go_branch": "master",'
' "project": "mod"'
diff --git a/main.star b/main.star
index 0e2c361..60ca5c1 100755
--- a/main.star
+++ b/main.star
@@ -202,8 +202,8 @@
properties["race_mode"] = True
if "longtest" in run_mods:
properties["env"] = {
- "GO_TEST_SHORT": 0,
- "GO_TEST_TIMEOUT_SCALE": 5,
+ "GO_TEST_SHORT": "0",
+ "GO_TEST_TIMEOUT_SCALE": "5",
}
luci.builder(
To view, visit change 479630. To unsubscribe, or for help writing mail filters, visit settings.
Reply all
Reply to author
Forward
0 new messages