[build] cmd/relui: initialize Mastodon, Swarming, Buildbucket clients on demand

0 views
Skip to first unread message

Gopher Robot (Gerrit)

unread,
4:07 PM (2 hours ago) 4:07 PM
to Dmitri Shuralyov, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Roland Shoemaker, Hongxiang Jiang, Go LUCI, Dmitri Shuralyov, golang-co...@googlegroups.com

Gopher Robot submitted the change

Change information

Commit message:
cmd/relui: initialize Mastodon, Swarming, Buildbucket clients on demand

The relui README says it should be possible to run it for development
by providing a Postgres database and by setting a single -listen-http
flag to some value. This has regressed.

Fix it by making some of the newer task dependencies initialize their
clients only when requested. This will still be the case in production,
but it becomes optional when running relui locally.
Change-Id: Ib3d3b20d4c0c9686febeab0a6eab8182f0d08e42
Reviewed-by: Dmitri Shuralyov <dmit...@google.com>
Reviewed-by: Hongxiang Jiang <hxj...@golang.org>
Auto-Submit: Dmitri Shuralyov <dmit...@golang.org>
Files:
  • M cmd/relui/deployment-prod.yaml
  • M cmd/relui/main.go
Change size: M
Delta: 2 files changed, 40 insertions(+), 28 deletions(-)
Branch: refs/heads/master
Submit Requirements:
  • requirement satisfiedCode-Review: +2 by Hongxiang Jiang, +1 by Dmitri Shuralyov
  • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: build
Gerrit-Branch: master
Gerrit-Change-Id: Ib3d3b20d4c0c9686febeab0a6eab8182f0d08e42
Gerrit-Change-Number: 599735
Gerrit-PatchSet: 2
Gerrit-Owner: Dmitri Shuralyov <dmit...@golang.org>
Gerrit-Reviewer: Dmitri Shuralyov <dmit...@golang.org>
Gerrit-Reviewer: Dmitri Shuralyov <dmit...@google.com>
Gerrit-Reviewer: Gopher Robot <go...@golang.org>
Gerrit-Reviewer: Hongxiang Jiang <hxj...@golang.org>
Gerrit-CC: Roland Shoemaker <rol...@golang.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages